linux-kernel - Re: [RFC PATCH 5/5] firmware: smccc: lfa: refresh fw details

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <850dc718-0268-43e5-81cd-2d9d2ec77327@nvidia.com>
Date: Thu, 18 Dec 2025 13:40:50 -0800
From: Vedashree Vidwans <vvidwans@...dia.com>
To: Matt Ochs <mochs@...dia.com>
Cc: "salman.nabi@....com" <salman.nabi@....com>,
 "sudeep.holla@....com" <sudeep.holla@....com>,
 "andre.przywara@....com" <andre.przywara@....com>,
 "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
 "mark.rutland@....com" <mark.rutland@....com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Varun Wadekar <vwadekar@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>, Vikram Sethi
 <vsethi@...dia.com>, "linux-coco@...ts.linux.dev"
 <linux-coco@...ts.linux.dev>, "ardb@...nel.org" <ardb@...nel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "chao.gao@...el.com" <chao.gao@...el.com>
Subject: Re: [RFC PATCH 5/5] firmware: smccc: lfa: refresh fw details



On 12/12/25 07:37, Matt Ochs wrote:
>> On Dec 8, 2025, at 16:13, Vedashree Vidwans <vvidwans@...dia.com> wrote:
>>
>> diff --git a/drivers/firmware/smccc/lfa_fw.c b/drivers/firmware/smccc/lfa_fw.c
>> index 24916fc53420..334090708405 100644
>> --- a/drivers/firmware/smccc/lfa_fw.c
>> +++ b/drivers/firmware/smccc/lfa_fw.c
> ...
>> + /*
>> + * Pass 2:
>> + *    If current FW components number is more than previous list, add new component nodes.
>> + */
>> + for (node_idx; node_idx < num_of_components; node_idx++) {
> 
> drivers/firmware/smccc/lfa_fw.c: In function ‘update_fw_images_tree’:
> drivers/firmware/smccc/lfa_fw.c:554:9: warning: statement with no effect [-Wunused-value]
>    554 |         for (node_idx; node_idx < num_of_components; node_idx++) {
>        |         ^~~
> 
> Please drop “node_idx” from the initializer statement.
> 
Thank you, I will include this change in next update.

Veda