linux-kernel - Re: [PATCH 2/4] dt-bindings: firmware: stratix10-svc: add fcs-config property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cfea9e6-0cc6-406f-9a4c-3564ef1e3569@kernel.org>
Date: Sat, 13 Dec 2025 04:21:21 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: hangsuan.wang@...era.com, linux-kernel <linux-kernel@...r.kernel.org>,
 devicetree <devicetree@...r.kernel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>,
 Thierry Reding <treding@...dia.com>, Lee Jones <lee@...nel.org>,
 Romain Gantois <romain.gantois@...tlin.com>,
 Andrea della Porta <andrea.porta@...e.com>,
 Andrei Simion <andrei.simion@...rochip.com>,
 Dinh Nguyen <dinguyen@...nel.org>, Mahesh Rao <mahesh.rao@...era.com>
Cc: Marek <marex@...x.de>, Simon <simon.k.r.goldschmidt@...il.com>,
 linux-drivers-review@...era.com,
 Muhammad Amirul Asyraf Mohamad Jamian
 <muhammad.amirul.asyraf.mohamad.jamian@...era.com>,
 Khairul Anuar Romli <khairul.anuar.romli@...era.com>
Subject: Re: [PATCH 2/4] dt-bindings: firmware: stratix10-svc: add fcs-config
 property

On 12/12/2025 12:35, hangsuan.wang@...era.com wrote:
> From: "Wang, Hang Suan" <hangsuan.wang@...era.com>
> 
> Altera SoC FPGA Crypto Service (fcs) provide hardware crypto features
> through mailbox. Fcs property has to be added to compliance with device
> tree schema fcs bindings and driver.

Last sentence is completely redundant. If you add new devices for some
"compliance" you do it wrong. We don't build hardware for "dt compliance"...

> 
> Signed-off-by: Wang, Hang Suan <hangsuan.wang@...era.com>
> ---
> ---
>  .../devicetree/bindings/firmware/intel,stratix10-svc.yaml     | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> index b42cfa78b28b..c105f8dc4b7d 100644
> --- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> +++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> @@ -62,6 +62,10 @@ properties:
>      $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
>      description: Optional child node for fpga manager to perform fabric configuration.
>  
> +  fcs-config:
> +    $ref: /schemas/misc/intel,agilex5-soc-fcs-config.yaml
> +    description: Optional child node for fcs Fpga Crypto Service (fcs) to perform SoC Crypto Engine.

You need to wrap according to Linux coding style. Anyway, above schema
is NAKed so is this child.

> +
>  required:
>    - compatible
>    - method


Best regards,
Krzysztof