linux-kernel - Re: [PATCH] ARM: dts: nxp/imx6: Drop unused .dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqK9OREenZjBHrDh7AqsyUXYOzTOhY4e0qHGzYkX8tacWQ@mail.gmail.com>
Date: Sun, 14 Dec 2025 08:41:56 -0600
From: Rob Herring <robh@...nel.org>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	imx@...ts.linux.dev, barebox@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: nxp/imx6: Drop unused .dtsi

On Sat, Dec 13, 2025 at 12:13 PM Marco Felsch <m.felsch@...gutronix.de> wrote:
>
> Hi Rob,
>
> On 25-12-12, Rob Herring (Arm) wrote:
> > These .dtsi files are not included anywhere in the tree and can't be
> > tested.
>
> not in the tree but by other projects, please see below.
>
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> >  .../dts/nxp/imx/imx6dl-kontron-samx6i.dtsi    | 12 -----
> >  .../dts/nxp/imx/imx6q-kontron-samx6i.dtsi     | 12 -----
> >  .../boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi  | 45 ----------------
> >  .../boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi  | 54 -------------------
> >  4 files changed, 123 deletions(-)
> >  delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
> >  delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
> >  delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> >  delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> >
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
> > deleted file mode 100644
> > index 5a9b819d7ee8..000000000000
> > --- a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
> > +++ /dev/null
> > @@ -1,12 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0 OR X11
> > -/*
> > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@...gutronix.de>
> > - */
> > -
> > -#include "imx6dl.dtsi"
> > -#include "imx6qdl-kontron-samx6i.dtsi"
> > -
> > -/ {
> > -     model = "Kontron SMARC-sAMX6i Dual-Lite/Solo";
> > -     compatible = "kontron,imx6dl-samx6i", "fsl,imx6dl";
> > -};
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
> > deleted file mode 100644
> > index e76963436079..000000000000
> > --- a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
> > +++ /dev/null
> > @@ -1,12 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0 OR X11
> > -/*
> > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@...gutronix.de>
> > - */
> > -
> > -#include "imx6q.dtsi"
> > -#include "imx6qdl-kontron-samx6i.dtsi"
> > -
> > -/ {
> > -     model = "Kontron SMARC-sAMX6i Quad/Dual";
> > -     compatible = "kontron,imx6q-samx6i", "fsl,imx6q";
> > -};
>
> I can't speak for the other two .dtsi files but both kontron .dtsi files
> are used by barebox:
>
>  - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6dl-samx6i.dts#L8
>  - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6q-samx6i.dts#L8
>
> Removing them here will cause a regression for barebox.

Please upstream something that uses the .dtsi. Other than the
undocumented barebox property, no reason these can't be.

Rob