linux-kernel - Re: [PATCH v6 4/8] drm/panel: sw43408: Add enable/disable and reset functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e67ef23-5f20-49aa-95eb-96be2e8bfccc@ixit.cz>
Date: Sun, 14 Dec 2025 15:43:48 +0100
From: David Heidelberg <david@...t.cz>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Sumit Semwal <sumit.semwal@...aro.org>,
 Casey Connolly <casey.connolly@...aro.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jesszhan0024@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 Dmitry Baryshkov <lumag@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Petr Hodina <phodina@...tonmail.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 phone-devel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v6 4/8] drm/panel: sw43408: Add enable/disable and reset
 functions

On 12/12/2025 16:39, David Heidelberg wrote:
> On 09/12/2025 23:51, David Heidelberg wrote:
>> On 09/12/2025 23:37, Dmitry Baryshkov wrote:
>>> On Mon, Dec 08, 2025 at 10:41:57AM +0100, David Heidelberg via B4 
>>> Relay wrote:
>>>> From: David Heidelberg <david@...t.cz>
>>>>
>>>> Introduce enable(), disable() and reset() functions.
>>>>
>>>> The enable() and disable() callbacks keep the symmetry in the commands
>>>> sent to the panel and also make a clearer distinction between panel
>>>> initialization and configuration.
>>>
>>> It's not just it. There is a difference between commands being sent in
>>> en/disable and prepare/unprepare.
>>
>> Thanks, I didn't know. Is there good rule how to distinguish, which 
>> command should go where?
> 
> How about I would "reduce" this patch to putting reset sequence into own 
> function, so Pixel 3 support could get merged?
> 
> The display will need more work anyway, would you be fine with this 
> approach?

As I did additional few changes, I'll sent v7 now, where I'll just 
abstract _reset() into own function.

I would address any other (non reviewed) changes when we manage to get 
panel with the driver behave stable on mainline/-next.

If you decide this change is worthy of inclusion in this series, I'm 
open to bring this commit back in future revisions.

Thank you
David