linux-kernel - Re: [PATCH v1 10/17] firmware: arm_scmi: optee: Make use of module_tee_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aT-5LtYnLSF_MwW4@sumit-X1>
Date: Mon, 15 Dec 2025 16:30:54 +0900
From: Sumit Garg <sumit.garg@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Jens Wiklander <jens.wiklander@...aro.org>,
	Sudeep Holla <sudeep.holla@....com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Cristian Marussi <cristian.marussi@....com>,
	op-tee@...ts.trustedfirmware.org, arm-scmi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 10/17] firmware: arm_scmi: optee: Make use of
 module_tee_client_driver()

On Thu, Dec 11, 2025 at 06:15:04PM +0100, Uwe Kleine-König wrote:
> Reduce boilerplate by using the newly introduced module_tee_client_driver().
> That takes care of assigning the driver's bus, so the explicit assigning
> in this driver can be dropped.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
>  drivers/firmware/arm_scmi/transports/optee.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@....qualcomm.com>

-Sumit

> 
> diff --git a/drivers/firmware/arm_scmi/transports/optee.c b/drivers/firmware/arm_scmi/transports/optee.c
> index dc0f46340153..8fdb80d3fabd 100644
> --- a/drivers/firmware/arm_scmi/transports/optee.c
> +++ b/drivers/firmware/arm_scmi/transports/optee.c
> @@ -612,23 +612,12 @@ static struct tee_client_driver scmi_optee_service_driver = {
>  	.id_table	= scmi_optee_service_id,
>  	.driver		= {
>  		.name = "scmi-optee",
> -		.bus = &tee_bus_type,
>  		.probe = scmi_optee_service_probe,
>  		.remove = scmi_optee_service_remove,
>  	},
>  };
>  
> -static int __init scmi_transport_optee_init(void)
> -{
> -	return driver_register(&scmi_optee_service_driver.driver);
> -}
> -module_init(scmi_transport_optee_init);
> -
> -static void __exit scmi_transport_optee_exit(void)
> -{
> -	driver_unregister(&scmi_optee_service_driver.driver);
> -}
> -module_exit(scmi_transport_optee_exit);
> +module_tee_client_driver(scmi_optee_service_driver);
>  
>  MODULE_AUTHOR("Etienne Carriere <etienne.carriere@...s.st.com>");
>  MODULE_DESCRIPTION("SCMI OPTEE Transport driver");
> -- 
> 2.47.3
>