linux-kernel - Re: [PATCH v1 13/17] firmware: tee_bnxt: Make use of tee bus methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aT-6DVAIS2sK6pxZ@sumit-X1>
Date: Mon, 15 Dec 2025 16:34:37 +0900
From: Sumit Garg <sumit.garg@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Jens Wiklander <jens.wiklander@...aro.org>,
	Michael Chan <michael.chan@...adcom.com>,
	Pavan Chebbi <pavan.chebbi@...adcom.com>,
	Rafał Miłecki <zajec5@...il.com>,
	op-tee@...ts.trustedfirmware.org, netdev@...r.kernel.org,
	linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 13/17] firmware: tee_bnxt: Make use of tee bus methods

On Thu, Dec 11, 2025 at 06:15:07PM +0100, Uwe Kleine-König wrote:
> The tee bus got dedicated callbacks for probe and remove.
> Make use of these. This fixes a runtime warning about the driver needing
> to be converted to the bus methods.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
>  drivers/firmware/broadcom/tee_bnxt_fw.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@....qualcomm.com>

-Sumit

> 
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index fbdf1aa97c82..a706c84eb2b6 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -181,9 +181,9 @@ static int optee_ctx_match(struct tee_ioctl_version_data *ver, const void *data)
>  	return (ver->impl_id == TEE_IMPL_ID_OPTEE);
>  }
>  
> -static int tee_bnxt_fw_probe(struct device *dev)
> +static int tee_bnxt_fw_probe(struct tee_client_device *bnxt_device)
>  {
> -	struct tee_client_device *bnxt_device = to_tee_client_device(dev);
> +	struct device *dev = &bnxt_device->dev;
>  	int ret, err = -ENODEV;
>  	struct tee_ioctl_open_session_arg sess_arg;
>  	struct tee_shm *fw_shm_pool;
> @@ -231,17 +231,15 @@ static int tee_bnxt_fw_probe(struct device *dev)
>  	return err;
>  }
>  
> -static int tee_bnxt_fw_remove(struct device *dev)
> +static void tee_bnxt_fw_remove(struct tee_client_device *bnxt_device)
>  {
>  	tee_shm_free(pvt_data.fw_shm_pool);
>  	tee_client_close_session(pvt_data.ctx, pvt_data.session_id);
>  	tee_client_close_context(pvt_data.ctx);
>  	pvt_data.ctx = NULL;
> -
> -	return 0;
>  }
>  
> -static void tee_bnxt_fw_shutdown(struct device *dev)
> +static void tee_bnxt_fw_shutdown(struct tee_client_device *bnxt_device)
>  {
>  	tee_shm_free(pvt_data.fw_shm_pool);
>  	tee_client_close_session(pvt_data.ctx, pvt_data.session_id);
> @@ -258,12 +256,12 @@ static const struct tee_client_device_id tee_bnxt_fw_id_table[] = {
>  MODULE_DEVICE_TABLE(tee, tee_bnxt_fw_id_table);
>  
>  static struct tee_client_driver tee_bnxt_fw_driver = {
> +	.probe		= tee_bnxt_fw_probe,
> +	.remove		= tee_bnxt_fw_remove,
> +	.shutdown	= tee_bnxt_fw_shutdown,
>  	.id_table	= tee_bnxt_fw_id_table,
>  	.driver		= {
>  		.name		= KBUILD_MODNAME,
> -		.probe		= tee_bnxt_fw_probe,
> -		.remove		= tee_bnxt_fw_remove,
> -		.shutdown	= tee_bnxt_fw_shutdown,
>  	},
>  };
>  
> -- 
> 2.47.3
>