linux-kernel - Re: [PATCH] ALSA: pcmcia: Fix resource leak in snd_pdacf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cy4ggld5.wl-tiwai@suse.de>
Date: Mon, 15 Dec 2025 10:11:50 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH] ALSA: pcmcia: Fix resource leak in snd_pdacf_probe error path

On Mon, 15 Dec 2025 10:04:33 +0100,
Haotian Zhang wrote:
> 
> When pdacf_config() fails, snd_pdacf_probe() returns the error code
> directly without freeing the sound card resources allocated by
> snd_card_new(), which leads to a memory leak.
> 
> Add proper error handling to free the sound card and clear the card
> list entry when pdacf_config() fails.
> 
> Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
> Suggested-by: Takashi Iwai <tiwai@...e.de>
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>

Applied now.  Thanks.


Takashi