linux-kernel - Re: [PATCH RESEND v2 5/6] drm/sitronix/st7571: split up the driver into a common and an i2c part

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87345ckt2n.fsf@ocarina.mail-host-address-is-not-set>
Date: Mon, 15 Dec 2025 10:11:44 +0100
From: Javier Martinez Canillas <javierm@...hat.com>
To: Marcus Folkesson <marcus.folkesson@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Marcus
 Folkesson <marcus.folkesson@...il.com>
Subject: Re: [PATCH RESEND v2 5/6] drm/sitronix/st7571: split up the driver
 into a common and an i2c part

Marcus Folkesson <marcus.folkesson@...il.com> writes:

> Split up the driver to make it possible to add support for hw interfaces
> other than I2C.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
> ---

[...]

> +config DRM_ST7571_I2C
> +	tristate "DRM support for Sitronix ST7567/ST7571 display panels (I2C)"
> +	depends on DRM_ST7571 && I2C
> +	select REGMAP_I2C

I think this should only be "select REGMAP", since you are not using the
REGMAP I2C support but instead have your own regmap write callback (due
the need to I2C_M_IGNORE_NAK).

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat