linux-kernel - Re: [PATCH 12/14] drm/scheduler: Describe @result in drm_sched_job

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f0fd860bf3466b9967d5a99ecd49eb93e0f7a19.camel@mailbox.org>
Date: Mon, 15 Dec 2025 13:24:46 +0100
From: Philipp Stanner <phasta@...lbox.org>
To: Bagas Sanjaya <bagasdotme@...il.com>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux AMDGPU
 <amd-gfx@...ts.freedesktop.org>,  Linux DRI Development
 <dri-devel@...ts.freedesktop.org>, Linux Filesystems Development
 <linux-fsdevel@...r.kernel.org>,  Linux Media
 <linux-media@...r.kernel.org>, linaro-mm-sig@...ts.linaro.org,
 kasan-dev@...glegroups.com,  Linux Virtualization
 <virtualization@...ts.linux.dev>, Linux Memory Management List
 <linux-mm@...ck.org>, Linux Network Bridge <bridge@...ts.linux.dev>, Linux
 Networking <netdev@...r.kernel.org>
Cc: Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, 
 Rodrigo Siqueira <siqueira@...lia.com>, Alex Deucher
 <alexander.deucher@....com>, Christian König
 <christian.koenig@....com>, David Airlie <airlied@...il.com>, Simona Vetter
 <simona@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann
 <tzimmermann@...e.de>, Matthew Brost <matthew.brost@...el.com>, Danilo
 Krummrich <dakr@...nel.org>, Philipp Stanner <phasta@...nel.org>, Alexander
 Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, Jan
 Kara <jack@...e.cz>, Sumit Semwal <sumit.semwal@...aro.org>,  Alexander
 Potapenko <glider@...gle.com>, Marco Elver <elver@...gle.com>, Dmitry
 Vyukov <dvyukov@...gle.com>, "Michael S. Tsirkin" <mst@...hat.com>, Jason
 Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Eugenio
 Pérez <eperezma@...hat.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Uladzislau Rezki <urezki@...il.com>, Nikolay
 Aleksandrov <razor@...ckwall.org>, Ido Schimmel <idosch@...dia.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Taimur Hassan <Syed.Hassan@....com>, Wayne Lin
 <Wayne.Lin@....com>, Alex Hung <alex.hung@....com>, Aurabindo Pillai
 <aurabindo.pillai@....com>, Dillon Varone <Dillon.Varone@....com>, George
 Shen <george.shen@....com>, Aric Cyr <aric.cyr@....com>, Cruise Hung
 <Cruise.Hung@....com>, Mario Limonciello <mario.limonciello@....com>, Sunil
 Khatri <sunil.khatri@....com>, Dominik Kaszewski
 <dominik.kaszewski@....com>, David Hildenbrand <david@...nel.org>, Peter
 Zijlstra <peterz@...radead.org>, Lorenzo Stoakes
 <lorenzo.stoakes@...cle.com>, Max Kellermann <max.kellermann@...os.com>,
 "Nysal Jan K.A." <nysal@...ux.ibm.com>, Ryan Roberts
 <ryan.roberts@....com>, Alexey Skidanov <alexey.skidanov@...el.com>, 
 Vlastimil Babka <vbabka@...e.cz>, Kent Overstreet
 <kent.overstreet@...ux.dev>, Vitaly Wool <vitaly.wool@...sulko.se>, Harry
 Yoo <harry.yoo@...cle.com>, Mateusz Guzik <mjguzik@...il.com>, NeilBrown
 <neil@...wn.name>, Amir Goldstein <amir73il@...il.com>, Jeff Layton
 <jlayton@...nel.org>, Ivan Lipski <ivan.lipski@....com>, Tao Zhou
 <tao.zhou1@....com>, YiPeng Chai <YiPeng.Chai@....com>, Hawking Zhang
 <Hawking.Zhang@....com>, Lyude Paul <lyude@...hat.com>, Daniel Almeida
 <daniel.almeida@...labora.com>, Luben Tuikov <luben.tuikov@....com>,
 Matthew Auld <matthew.auld@...el.com>, Roopa Prabhu
 <roopa@...ulusnetworks.com>, Mao Zhu <zhumao001@...suo.com>, Shaomin Deng
 <dengshaomin@...rlc.com>, Charles Han <hanchunchao@...pur.com>, Jilin Yuan
 <yuanjilin@...rlc.com>, Swaraj Gaikwad <swarajgaikwad1925@...il.com>,
 George Anthony Vernon <contact@...rnon.com>
Subject: Re: [PATCH 12/14] drm/scheduler: Describe @result in
 drm_sched_job_done()

nit about commit title:
We use "drm/sched:" as prefix nowadays

On Mon, 2025-12-15 at 18:39 +0700, Bagas Sanjaya wrote:
> Sphinx reports kernel-doc warning:
> 
> WARNING: ./drivers/gpu/drm/scheduler/sched_main.c:367 function parameter 'result' not described in 'drm_sched_job_done'
> 
> Describe @result parameter to fix it
> 

Thx for fixing this!

> .
> 
> Fixes: 539f9ee4b52a8b ("drm/scheduler: properly forward fence errors")
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 1d4f1b822e7b76..4f844087fd48eb 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_scheduler *sched)
>  /**
>   * drm_sched_job_done - complete a job
>   * @s_job: pointer to the job which is done
> + * @result: job result

"error code for the job's finished-fence" would be a bit better and
more verbose.

With that:

Reviewed-by: Philipp Stanner <phasta@...nel.org>

>   *
>   * Finish the job's fence and resubmit the work items.
>   */