linux-kernel - Re: [PATCH 07/14] fs: Describe @isnew parameter in ilookup5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qxbixswc7daxb3y7o7ebmy34dpa3uv6i5vc2fnj2p6f3sckulk@vcbuzldig7al>
Date: Mon, 15 Dec 2025 13:57:39 +0100
From: Jan Kara <jack@...e.cz>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux AMDGPU <amd-gfx@...ts.freedesktop.org>, Linux DRI Development <dri-devel@...ts.freedesktop.org>, 
	Linux Filesystems Development <linux-fsdevel@...r.kernel.org>, Linux Media <linux-media@...r.kernel.org>, 
	linaro-mm-sig@...ts.linaro.org, kasan-dev@...glegroups.com, 
	Linux Virtualization <virtualization@...ts.linux.dev>, Linux Memory Management List <linux-mm@...ck.org>, 
	Linux Network Bridge <bridge@...ts.linux.dev>, Linux Networking <netdev@...r.kernel.org>, 
	Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, 
	Rodrigo Siqueira <siqueira@...lia.com>, Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	Matthew Brost <matthew.brost@...el.com>, Danilo Krummrich <dakr@...nel.org>, 
	Philipp Stanner <phasta@...nel.org>, Alexander Viro <viro@...iv.linux.org.uk>, 
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, Sumit Semwal <sumit.semwal@...aro.org>, 
	Alexander Potapenko <glider@...gle.com>, Marco Elver <elver@...gle.com>, 
	Dmitry Vyukov <dvyukov@...gle.com>, "Michael S. Tsirkin" <mst@...hat.com>, 
	Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, 
	Eugenio Pérez <eperezma@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Uladzislau Rezki <urezki@...il.com>, Nikolay Aleksandrov <razor@...ckwall.org>, 
	Ido Schimmel <idosch@...dia.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Taimur Hassan <Syed.Hassan@....com>, Wayne Lin <Wayne.Lin@....com>, Alex Hung <alex.hung@....com>, 
	Aurabindo Pillai <aurabindo.pillai@....com>, Dillon Varone <Dillon.Varone@....com>, 
	George Shen <george.shen@....com>, Aric Cyr <aric.cyr@....com>, Cruise Hung <Cruise.Hung@....com>, 
	Mario Limonciello <mario.limonciello@....com>, Sunil Khatri <sunil.khatri@....com>, 
	Dominik Kaszewski <dominik.kaszewski@....com>, David Hildenbrand <david@...nel.org>, 
	Peter Zijlstra <peterz@...radead.org>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, 
	Max Kellermann <max.kellermann@...os.com>, "Nysal Jan K.A." <nysal@...ux.ibm.com>, 
	Ryan Roberts <ryan.roberts@....com>, Alexey Skidanov <alexey.skidanov@...el.com>, 
	Vlastimil Babka <vbabka@...e.cz>, Kent Overstreet <kent.overstreet@...ux.dev>, 
	Vitaly Wool <vitaly.wool@...sulko.se>, Harry Yoo <harry.yoo@...cle.com>, 
	Mateusz Guzik <mjguzik@...il.com>, NeilBrown <neil@...wn.name>, Amir Goldstein <amir73il@...il.com>, 
	Jeff Layton <jlayton@...nel.org>, Ivan Lipski <ivan.lipski@....com>, Tao Zhou <tao.zhou1@....com>, 
	YiPeng Chai <YiPeng.Chai@....com>, Hawking Zhang <Hawking.Zhang@....com>, 
	Lyude Paul <lyude@...hat.com>, Daniel Almeida <daniel.almeida@...labora.com>, 
	Luben Tuikov <luben.tuikov@....com>, Matthew Auld <matthew.auld@...el.com>, 
	Roopa Prabhu <roopa@...ulusnetworks.com>, Mao Zhu <zhumao001@...suo.com>, 
	Shaomin Deng <dengshaomin@...rlc.com>, Charles Han <hanchunchao@...pur.com>, 
	Jilin Yuan <yuanjilin@...rlc.com>, Swaraj Gaikwad <swarajgaikwad1925@...il.com>, 
	George Anthony Vernon <contact@...rnon.com>
Subject: Re: [PATCH 07/14] fs: Describe @isnew parameter in ilookup5_nowait()

On Mon 15-12-25 18:38:55, Bagas Sanjaya wrote:
> Sphinx reports kernel-doc warning:
> 
> WARNING: ./fs/inode.c:1607 function parameter 'isnew' not described in 'ilookup5_nowait'
> 
> Describe the parameter.
> 
> Fixes: a27628f4363435 ("fs: rework I_NEW handling to operate without fences")
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

...

> @@ -1593,6 +1593,7 @@ EXPORT_SYMBOL(igrab);
>   * @hashval:	hash value (usually inode number) to search for
>   * @test:	callback used for comparisons between inodes
>   * @data:	opaque data pointer to pass to @test
> + * @isnew:	whether the inode is new or not

I'm sorry but this is true but misleading at the same time. I'd write there
something like:

 * @isnew:    return argument telling whether I_NEW was set when the inode
              was found in hash (the caller needs to wait for I_NEW to clear).


								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR