| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <09a773bb51331940e76fbeb5e8128c183bf6d621.camel@phytec.de>
Date: Tue, 16 Dec 2025 15:29:55 +0000
From: Christoph Stoidner <C.Stoidner@...tec.de>
To: Marco Felsch <m.felsch@...gutronix.de>, Primoz Fiser
<primoz.fiser@...ik.com>
CC: Abel Vesa <abelvesa@...nel.org>, Peng Fan <peng.fan@....com>, Michael
Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Shawn
Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Rob
Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
Dooley <conor+dt@...nel.org>, Andrej Picej <andrej.picej@...ik.com>,
Christian Hemp <C.Hemp@...tec.de>,
Stefan Müller-Klieser <S.Mueller-Klieser@...tec.de>,
Norbert Wesp <N.Wesp@...tec.de>, "linux-clk@...r.kernel.org"
<linux-clk@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: imx93-phyboard-segin: Add peb-av-02
overlay
Hi Marco,
On Mo, 2025-12-15 at 18:07 +0100, Marco Felsch wrote:
> Hi Primoz,
>
> On 25-12-03, Primoz Fiser wrote:
> > Hi Marco,
> >
> > On 2. 12. 25 14:44, Marco Felsch wrote:
> > > From: Andrej Picej <andrej.picej@...ik.com>
> > >
> > > Add overlay for Audio-Video module PEB-AV-02. Add support for
> > > panel
> > > display, capacitive touchscreen and backlight.
> > >
> > > For now the backlight is configured as a GPIO, brightness of the
> > > display
> > > can not be set. When the FLEXIO PWM driver is available this
> > > should be
> > > switched to PWM backlight driver.
> > >
> > > Signed-off-by: Andrej Picej <andrej.picej@...ik.com>
> > > [rework commit message, use local regulator, remove compatible]
> > > Signed-off-by: Primoz Fiser <primoz.fiser@...ik.com>
> > > Signed-off-by: Christian Hemp <c.hemp@...tec.de>
> > > [m.felsch@...gutronix.de: cleanup downstream commit]
> > > Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>
> > > ---
> > > arch/arm64/boot/dts/freescale/Makefile | 2 +
> > > .../freescale/imx93-phyboard-segin-peb-av-02.dtso | 135
> > > +++++++++++++++++++++
> > > 2 files changed, 137 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > > b/arch/arm64/boot/dts/freescale/Makefile
> > > index
> > > 525ef180481d331e9c4decd092b7b831c497b67e..27e27ac29e82bc0692e86c2
> > > ba15c240dc9fbe1c6 100644
> > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > @@ -357,10 +357,12 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-
> > > nash.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb
> > >
> > > imx93-phyboard-nash-peb-wlbt-07-dtbs += imx93-phyboard-nash.dtb
> > > imx93-phyboard-nash-peb-wlbt-07.dtbo
> > > +imx93-phyboard-segin-peb-av-02-dtbs += imx93-phyboard-segin.dtb
> > > imx93-phyboard-segin-peb-av-02.dtbo
> > > imx93-phyboard-segin-peb-eval-01-dtbs += imx93-phyboard-
> > > segin.dtb imx93-phyboard-segin-peb-eval-01.dtbo
> > > imx93-phyboard-segin-peb-wlbt-05-dtbs += imx93-phyboard-
> > > segin.dtb imx93-phyboard-segin-peb-wlbt-05.dtbo
> > > imx93-phycore-rpmsg-dtbs += imx93-phyboard-nash.dtb imx93-
> > > phyboard-segin.dtb imx93-phycore-rpmsg.dtbo
> > > dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-nash-peb-wlbt-07.dtb
> > > +dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin-peb-av-02.dtb
> >
> > Here you need to rebase since new commits on linux-next.
>
> Argh.. will do.
>
> > > dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin-peb-eval-01.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin-peb-wlbt-05.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx93-phycore-rpmsg.dtb
> > > diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin-
> > > peb-av-02.dtso b/arch/arm64/boot/dts/freescale/imx93-phyboard-
> > > segin-peb-av-02.dtso
> > > new file mode 100644
> > > index
> > > 0000000000000000000000000000000000000000..2e7074e402dc8fdeb1568d4
> > > f2d4960431e972501
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin-peb-av-
> > > 02.dtso
> > > @@ -0,0 +1,135 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > +/*
> > > + * Copyright (C) 2025 PHYTEC Messtechnik GmbH
> > > + * Copyright (C) 2025 Pengutronix
> > > + *
> > > + * Author: Andrej Picej <andrej.picej@...ik.com>
> > > + * Author: Marco Felsch <kernel@...gutronix.de>
> > > + */
> > > +
> > > +#include <dt-bindings/clock/imx93-clock.h>
> > > +#include <dt-bindings/gpio/gpio.h>
> > > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > > +#include "imx93-pinfunc.h"
> > > +
> > > +/dts-v1/;
> > > +/plugin/;
> > > +
> > > +&{/} {
> > > + /* TODO: Convert to PWM backlight once the FlexIO PWM is
> > > supported */
> > > + backlight: backlight {
> > > + compatible = "gpio-backlight";
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_backlight>;
> > > + gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
> > > + };
> > > +
> > > + panel {
> > > + compatible = "edt,etm0700g0edh6";
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_panel>;
> > > +
> > > + backlight = <&backlight>;
> > > + enable-gpios = <&gpio4 29 GPIO_ACTIVE_HIGH>;
> > > + power-supply = <®_x71_vcc_3v3>;
> > > +
> > > + port {
> > > + panel_in: endpoint {
> > > + remote-endpoint =
> > > <&dpi_to_panel>;
> > > + };
> > > + };
> > > + };
> > > +
> > > + reg_x71_vcc_3v3: regulator-x71-vcc-3v3 {
> >
> > I just checked the schematics.
> >
> > Can we rename this to reg_vcc_3v3_con in v2 maybe?
> >
> > > + compatible = "regulator-fixed";
> > > + regulator-name = "X71-VCC3V3";
> >
> > And this to "VCC3V3_CON"?
> >
> > The reasoning behind is that "X71-VCC3V3" voltage doesn't exist on
> > the
> > schematics, while there is actually "VCC3V3_CON" voltage supplying
> > the
> > display panel.
>
> I know that "X71-VCC3V3" doesn't exist, I also thought about
> "X71:VCC3V3" to make it clear. Why I mentioned the X71 in the first
> place was to not cause any naming conflict. I would like to keep the
> X71
> naming since "VCC3V3_CON" really is the "X71-VCC3V3" with some
> filters
> applied. Anyway, I can change this of course.
>
> > > + regulator-max-microvolt = <3300000>;
> > > + regulator-min-microvolt = <3300000>;
> > > + };
> > > +};
> > > +
> > > +&dpi_bridge {
> > > + status = "okay";
> > > +};
> > > +
> > > +&dpi_to_panel {
> > > + remote-endpoint = <&panel_in>;
> > > + bus-width = <18>;
> > > +};
> > > +
> > > +&lcdif {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_lcdif>;
> > > + assigned-clocks = <&clk IMX93_CLK_VIDEO_PLL>;
> > > + assigned-clock-rates = <332600000>;
> > > + status = "okay";
> > > +};
> > > +
> > > +&lpi2c2 {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + touchscreen@38 {
> > > + compatible = "edt,edt-ft5406";
> > > + reg = <0x38>;
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_touchscreen>;
> > > + interrupt-parent = <&gpio4>;
> > > + interrupts = <12 IRQ_TYPE_EDGE_FALLING>;
> > > + reset-gpios = <&gpio4 1 GPIO_ACTIVE_LOW>;
> > > + touchscreen-size-x = <1792>;
> > > + touchscreen-size-y = <1024>;
> >
> > Please add "wakeup-source" property here like in the downstream
> > commit.
> >
> > With this in place, panel touch can be used to wake up the board
> > from sleep.
>
> Is this a required feature? Touchscreens with no certain
> low-power mode handlig (e.g. reduced scanning time) can draw much
> power
> in suspend.
>
> I can add it if Phytec is aware of this fact and still wants to have
> thsi feature.
Yes, please add this "wakeup-source" property again. This feature
shall work on our platform by default. And one who wants to avoid
touchscreen as wakeup-source can modify the device-tree or disable
it for wakeup via policy/sysfs.
Thanks,
Christoph
>
> > Last but not least, can you add the vcc and iovcc supply regulators
> > here
> > like in the downstream commit:
> >
> > vcc-supply = <®_vcc_3v3_con>;
> > iovcc-supply = <®_vcc_3v3_con>;
> >
> > to get rid of the following warnings:
> >
> > edt_ft5x06 1-0038: supply vcc not found, using dummy regulator
> > edt_ft5x06 1-0038: supply iovcc not found, using dummy regulator
>
> Will do.
>
> > Anyway, I tested the display on the segin board with latest linux-
> > next
> > and your patches. Can report display, touch and backlight work as
> > expected.
> >
> > Thank you!
> >
> > Tested-by: Primoz Fiser <primoz.fiser@...ik.com>
>
> Regards,
> Marco
>
> >
> > BR,
> > Primoz
> >
> > > + };
> > > +};
> > > +
> > > +&media_blk_ctrl {
> > > + status = "okay";
> > > +};
> > > +
> > > +&iomuxc {
> > > + pinctrl_backlight: backlightgrp {
> > > + fsl,pins = <
> > > + MX93_PAD_CCM_CLKO3__GPIO4_IO28
> > > 0x1133e
> > > + >;
> > > + };
> > > +
> > > + pinctrl_lcdif: lcdifgrp {
> > > + fsl,pins = <
> > > + MX93_PAD_GPIO_IO00__MEDIAMIX_DISP_CLK
> > > 0x50e
> > > + MX93_PAD_GPIO_IO01__MEDIAMIX_DISP_DE
> > > 0x50e
> > > + MX93_PAD_GPIO_IO02__MEDIAMIX_DISP_VSYNC
> > > 0x50e
> > > + MX93_PAD_GPIO_IO03__MEDIAMIX_DISP_HSYNC
> > > 0x50e
> > > + MX93_PAD_GPIO_IO04__MEDIAMIX_DISP_DATA00
> > > 0x50e
> > > + MX93_PAD_GPIO_IO05__MEDIAMIX_DISP_DATA01
> > > 0x50e
> > > + MX93_PAD_GPIO_IO06__MEDIAMIX_DISP_DATA02
> > > 0x50e
> > > + MX93_PAD_GPIO_IO07__MEDIAMIX_DISP_DATA03
> > > 0x50e
> > > + MX93_PAD_GPIO_IO08__MEDIAMIX_DISP_DATA04
> > > 0x50e
> > > + MX93_PAD_GPIO_IO09__MEDIAMIX_DISP_DATA05
> > > 0x51e
> > > + MX93_PAD_GPIO_IO10__MEDIAMIX_DISP_DATA06
> > > 0x50e
> > > + MX93_PAD_GPIO_IO11__MEDIAMIX_DISP_DATA07
> > > 0x50e
> > > + MX93_PAD_GPIO_IO12__MEDIAMIX_DISP_DATA08
> > > 0x50e
> > > + MX93_PAD_GPIO_IO13__MEDIAMIX_DISP_DATA09
> > > 0x50e
> > > + MX93_PAD_GPIO_IO14__MEDIAMIX_DISP_DATA10
> > > 0x50e
> > > + MX93_PAD_GPIO_IO15__MEDIAMIX_DISP_DATA11
> > > 0x50e
> > > + MX93_PAD_GPIO_IO16__MEDIAMIX_DISP_DATA12
> > > 0x506
> > > + MX93_PAD_GPIO_IO17__MEDIAMIX_DISP_DATA13
> > > 0x506
> > > + MX93_PAD_GPIO_IO18__MEDIAMIX_DISP_DATA14
> > > 0x506
> > > + MX93_PAD_GPIO_IO19__MEDIAMIX_DISP_DATA15
> > > 0x506
> > > + MX93_PAD_GPIO_IO20__MEDIAMIX_DISP_DATA16
> > > 0x506
> > > + MX93_PAD_GPIO_IO21__MEDIAMIX_DISP_DATA17
> > > 0x506
> > > + >;
> > > + };
> > > +
> > > + pinctrl_panel: panelgrp {
> > > + fsl,pins = <
> > > + MX93_PAD_CCM_CLKO4__GPIO4_IO29
> > > 0x1133e
> > > + >;
> > > + };
> > > +
> > > + pinctrl_touchscreen: touchscreengrp {
> > > + fsl,pins = <
> > > + MX93_PAD_ENET1_MDIO__GPIO4_IO01
> > > 0x11e
> > > + MX93_PAD_ENET1_RD2__GPIO4_IO12
> > > 0x1133e
> > > + >;
> > > + };
> > > +};
> > >
> >
> > --
> > Primoz Fiser
> > phone: +386-41-390-545
> > email: primoz.fiser@...ik.com
> > --
> > Norik systems d.o.o.
> > Your embedded software partner
> > Slovenia, EU
> > phone: +386-41-540-545
> > email: info@...ik.com
> >
> >
>
Powered by blists - more mailing lists