[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251218161953.wjiruxqmib7lchol@pengutronix.de>
Date: Thu, 18 Dec 2025 17:19:53 +0100
From: Marco Felsch <m.felsch@...gutronix.de>
To: Christoph Stoidner <C.Stoidner@...tec.de>
Cc: Primoz Fiser <primoz.fiser@...ik.com>, Abel Vesa <abelvesa@...nel.org>,
Peng Fan <peng.fan@....com>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Andrej Picej <andrej.picej@...ik.com>,
Christian Hemp <C.Hemp@...tec.de>,
Stefan Müller-Klieser <S.Mueller-Klieser@...tec.de>,
Norbert Wesp <N.Wesp@...tec.de>,
"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: imx93-phyboard-segin: Add peb-av-02
overlay
On 25-12-16, Christoph Stoidner wrote:
> Hi Marco,
>
> On Mo, 2025-12-15 at 18:07 +0100, Marco Felsch wrote:
> > Hi Primoz,
> >
> > On 25-12-03, Primoz Fiser wrote:
...
> > > > + touchscreen@38 {
> > > > + compatible = "edt,edt-ft5406";
> > > > + reg = <0x38>;
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&pinctrl_touchscreen>;
> > > > + interrupt-parent = <&gpio4>;
> > > > + interrupts = <12 IRQ_TYPE_EDGE_FALLING>;
> > > > + reset-gpios = <&gpio4 1 GPIO_ACTIVE_LOW>;
> > > > + touchscreen-size-x = <1792>;
> > > > + touchscreen-size-y = <1024>;
> > >
> > > Please add "wakeup-source" property here like in the downstream
> > > commit.
> > >
> > > With this in place, panel touch can be used to wake up the board
> > > from sleep.
> >
> > Is this a required feature? Touchscreens with no certain
> > low-power mode handlig (e.g. reduced scanning time) can draw much
> > power
> > in suspend.
> >
> > I can add it if Phytec is aware of this fact and still wants to have
> > thsi feature.
>
> Yes, please add this "wakeup-source" property again. This feature
> shall work on our platform by default. And one who wants to avoid
> touchscreen as wakeup-source can modify the device-tree or disable
> it for wakeup via policy/sysfs.
Okay, I added the property for the v2.
Regards,
Marco
Powered by blists - more mailing lists