linux-kernel - Re: [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0b4cfd3-2773-4a07-a3ba-3dc600ca69ac@acm.org>
Date: Tue, 16 Dec 2025 09:57:56 -0800
From: Bart Van Assche <bvanassche@....org>
To: Christoph Hellwig <hch@...radead.org>
Cc: Po-Wen Kao <powenkao@...gle.com>,
 "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER"
 <linux-scsi@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support

On 12/16/25 2:44 AM, Christoph Hellwig wrote:
> On Mon, Dec 15, 2025 at 08:47:03AM -0800, Bart Van Assche wrote:
>> (a) There is code in the SCSI error handler that submits SCSI commands
>>      with a data buffer. Hence, disabling encryption if and only if the
>>      data buffer length is zero can't fix the reported problem. From
>>      scsi_eh_prep_cmnd() in drivers/scsi/scsi_error.c:
> 
> This still does not actually transfer data to the media, and thus
> is not affected by inline encryption.

Hi Christoph,

Agreed that neither REQUEST SENSE nor any of the other SCSI commands
submitted by the SCSI error handler access the storage medium. However,
even if Po-Wen's patch would be modified such that it checks the SCSI
CDB to verify whether or not the SCSI command accesses the medium, the
other concerns that I mentioned still apply. So if nobody objects I
propose to repost patch "[PATCH v2 1/1] scsi: core: Fix error handler
encryption support" with v2 bumped to v3.

Thanks,

Bart.