linux-kernel - Re: [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUE4Kf73OxxO7r-K@infradead.org>
Date: Tue, 16 Dec 2025 02:44:57 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Christoph Hellwig <hch@...radead.org>, Po-Wen Kao <powenkao@...gle.com>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER" <linux-scsi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support

On Mon, Dec 15, 2025 at 08:47:03AM -0800, Bart Van Assche wrote:
> > I don't think callers vs calle is the important part here.  It is to
> > check if any actual data is tranferred instead of special casing EH
> > commands.
> 
> Hi Christoph,
> 
> Do you agree with the following?
> 
> (a) There is code in the SCSI error handler that submits SCSI commands
>     with a data buffer. Hence, disabling encryption if and only if the
>     data buffer length is zero can't fix the reported problem. From
>     scsi_eh_prep_cmnd() in drivers/scsi/scsi_error.c:

This still does not actually transfer data to the media, and thus
is not affected by inline encryption.