linux-kernel - Re: [PATCH net-next] ice: access @pp through netmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUDd9lLy76sBejrP@casper.infradead.org>
Date: Tue, 16 Dec 2025 04:20:06 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Byungchul Park <byungchul@...com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, linux-kernel@...r.kernel.org,
	kernel_team@...ynix.com, harry.yoo@...cle.com, david@...hat.com,
	toke@...hat.com, asml.silence@...il.com, almasrymina@...gle.com,
	anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH net-next] ice: access @pp through netmem_desc instead of
 page

On Tue, Dec 16, 2025 at 01:07:23PM +0900, Byungchul Park wrote:
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
>  		rx_buf = &rx_ring->rx_fqes[i];
>  		page = __netmem_to_page(rx_buf->netmem);
>  		received_buf = page_address(page) + rx_buf->offset +
> -			       page->pp->p.offset;
> +			       pp_page_to_nmdesc(page)->pp->p.offset;

Shouldn't we rather use:

		nmdesc = __netmem_to_nmdesc(rx_buf->netmem);
		received_buf = nmdesc_address(nmdesc) + rx_buf->offset +
				nmdesc->pp->p_offset;

(also. i think we're missing a nmdesc_address() function in our API).