linux-kernel - Re: [PATCH] bug: hush suggest-attribute=format for __warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251215202430.c35c2d29c4f9ff614d2ab534@linux-foundation.org>
Date: Mon, 15 Dec 2025 20:24:30 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org,
 kees@...nel.org, acarmina@...hat.com, jpoimboe@...nel.org,
 mark.rutland@....com, maciej.wieczor-retman@...el.com, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf()

On Sun, 07 Dec 2025 03:53:18 +0000 Brendan Jackman <jackmanb@...gle.com> wrote:

> Recent additions to this function cause GCC 14.3.0 to get excited and
> suggest a missing attribute:
> 
> lib/bug.c: In function ‘__warn_printf’:
> lib/bug.c:187:25: error: function ‘__warn_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>   187 |                         vprintk(fmt, *args);
>       |                         ^~~~~~~
> 
> Disable the diagnostic locally, following the pattern used for stuff
> like va_format().
> 

Question please.  Why are we suppressing the warning instead of
addressing it, as Andy attempts to do in
https://lkml.kernel.org/r/20251208141618.2805983-1-andriy.shevchenko@linux.intel.com?

I went off and looked at the commit which did this to va_format() but
it didn't tell me.