linux-kernel - Re: [PATCH] dt-bindings: power: supply: Add Silergy SY6974B charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43033462-bdea-48b2-9108-acc29b60e82e@kernel.org>
Date: Tue, 16 Dec 2025 06:33:25 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "tian.ge" <tian.ge@...ergymicro.com>, sre@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, lei.zhang@...ergycorp.com,
 frank.fan@...ergymicro.com
Subject: Re: [PATCH] dt-bindings: power: supply: Add Silergy SY6974B charger

On 16/12/2025 03:18, tian.ge wrote:
> Add bindings for the Silergy SY6974B I2C controlled charger.

Why? Where is any user of this?

Plus this was not tested, so I finish review here. You did not follow
basic DT binding rules, please read first writing-bindings doc or my
DTS101 talk.

Best regards,
Krzysztof