linux-kernel - Re: [PATCH] dt-bindings: power: supply: Add Silergy SY6974B charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251217093058.183290-1-tian.ge@silergymicro.com>
Date: Wed, 17 Dec 2025 17:30:58 +0800
From: "tian.ge" <tian.ge@...ergymicro.com>
To: krzk@...nel.org
Cc: krzk+dt@...nel.org, robh@...nel.org, conor+dt@...nel.org, sre@...nel.org, 
 devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, lei.zhang@...ergycorp.com,
 frank.fan@...ergymicro.com
Subject: Re: [PATCH] dt-bindings: power: supply: Add Silergy SY6974B charger

On Tue, 16 Dec 2025 06:33:25 +0100, Krzysztof Kozlowski<krzk@...nel.org> wrote:

> On 16/12/2025 03:18, tian.ge wrote:
> > Add bindings for the Silergy SY6974B I2C controlled charger.
> 
> Why? Where is any user of this?
> 
> Plus this was not tested, so I finish review here. You did not follow
> basic DT binding rules, please read first writing-bindings doc or my
> DTS101 talk.
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

Thanks for your feedback, and thanks to the bot for the dt-bindings-check report!

Apologies for the issues in my initial submission:
1. I didn't run `make dt_binding_check` for the DT binding (unaware of this mandatory step);
2. The driver and DT binding were sent as separate patches with different recipients, making the driver invisible to DT maintainers.

Clarification: The SY6974B driver patch is already submitted (Message-Id: 20251216021408.654926-1-tian.ge@...ergymicro.com). It’s the direct user of this DT binding.

I’ve now fixed all issues:
1. Updated DT binding: Replaced all 'sy,' prefixes with 'silergy,' (passes `make dt_binding_check` and `yamllint`);
2. Synced driver: Parses 'silergy,xxx' properties (consistent with binding, compiles cleanly).

I’ll resubmit a unified v2 series (cover letter + DT binding + driver) to all relevant maintainers (DT + power supply) to resolve the association issue.

Thanks,
Tian
 This email contains information from Silergy Corp. that may be confidential or privileged. Such information is solely for the intended recipient(s).Any review, retransmission, dissemination, disclosure or other use of this information by persons or entities other than intended recipient(s) is strictly prohibited. If you have received this email in error, please notify the sender immediately and delete this email together with any correspondences.