linux-kernel - Re: [PATCH v2 08/17] efi: stmm: Make use of module_tee_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC_iWjLG7o96E=9W-cjJ=_622RFg-b9t6hQnMrSmgHS+ThaXyw@mail.gmail.com>
Date: Tue, 16 Dec 2025 11:20:52 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Jens Wiklander <jens.wiklander@...aro.org>, Ard Biesheuvel <ardb@...nel.org>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Sumit Garg <sumit.garg@....qualcomm.com>, Jan Kiszka <jan.kiszka@...mens.com>, 
	linux-efi@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	op-tee@...ts.trustedfirmware.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 08/17] efi: stmm: Make use of module_tee_client_driver()

On Mon, 15 Dec 2025 at 16:17, Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> Reduce boilerplate by using the newly introduced module_tee_client_driver().
> That takes care of assigning the driver's bus, so the explicit assigning
> in this driver can be dropped.
>
> Reviewed-by: Sumit Garg <sumit.garg@....qualcomm.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---

Acked-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>

>  drivers/firmware/efi/stmm/tee_stmm_efi.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/firmware/efi/stmm/tee_stmm_efi.c b/drivers/firmware/efi/stmm/tee_stmm_efi.c
> index 65c0fe1ba275..5903811858b6 100644
> --- a/drivers/firmware/efi/stmm/tee_stmm_efi.c
> +++ b/drivers/firmware/efi/stmm/tee_stmm_efi.c
> @@ -584,24 +584,12 @@ static struct tee_client_driver tee_stmm_efi_driver = {
>         .id_table       = tee_stmm_efi_id_table,
>         .driver         = {
>                 .name           = "tee-stmm-efi",
> -               .bus            = &tee_bus_type,
>                 .probe          = tee_stmm_efi_probe,
>                 .remove         = tee_stmm_efi_remove,
>         },
>  };
>
> -static int __init tee_stmm_efi_mod_init(void)
> -{
> -       return driver_register(&tee_stmm_efi_driver.driver);
> -}
> -
> -static void __exit tee_stmm_efi_mod_exit(void)
> -{
> -       driver_unregister(&tee_stmm_efi_driver.driver);
> -}
> -
> -module_init(tee_stmm_efi_mod_init);
> -module_exit(tee_stmm_efi_mod_exit);
> +module_tee_client_driver(tee_stmm_efi_driver);
>
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Ilias Apalodimas <ilias.apalodimas@...aro.org>");
> --
> 2.47.3
>