linux-kernel - Re: [PATCH v2 09/17] efi: stmm: Make use of tee bus methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC_iWj+TevKq7TzPQ4_eEhu0rJJ03PV=ASf7SwTszp-mJY6Vzw@mail.gmail.com>
Date: Tue, 16 Dec 2025 11:19:39 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Jens Wiklander <jens.wiklander@...aro.org>, Ard Biesheuvel <ardb@...nel.org>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Sumit Garg <sumit.garg@....qualcomm.com>, Jan Kiszka <jan.kiszka@...mens.com>, 
	linux-efi@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	op-tee@...ts.trustedfirmware.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 09/17] efi: stmm: Make use of tee bus methods

On Mon, 15 Dec 2025 at 16:17, Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> The tee bus got dedicated callbacks for probe and remove.
> Make use of these. This fixes a runtime warning about the driver needing
> to be converted to the bus methods.
>
> Reviewed-by: Sumit Garg <sumit.garg@....qualcomm.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>

>  drivers/firmware/efi/stmm/tee_stmm_efi.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/firmware/efi/stmm/tee_stmm_efi.c b/drivers/firmware/efi/stmm/tee_stmm_efi.c
> index 5903811858b6..7b04dd649629 100644
> --- a/drivers/firmware/efi/stmm/tee_stmm_efi.c
> +++ b/drivers/firmware/efi/stmm/tee_stmm_efi.c
> @@ -520,8 +520,9 @@ static void tee_stmm_restore_efivars_generic_ops(void)
>         efivars_generic_ops_register();
>  }
>
> -static int tee_stmm_efi_probe(struct device *dev)
> +static int tee_stmm_efi_probe(struct tee_client_device *tee_dev)
>  {
> +       struct device *dev = &tee_dev->dev;
>         struct tee_ioctl_open_session_arg sess_arg;
>         efi_status_t ret;
>         int rc;
> @@ -571,21 +572,19 @@ static int tee_stmm_efi_probe(struct device *dev)
>         return 0;
>  }
>
> -static int tee_stmm_efi_remove(struct device *dev)
> +static void tee_stmm_efi_remove(struct tee_client_device *dev)
>  {
>         tee_stmm_restore_efivars_generic_ops();
> -
> -       return 0;
>  }
>
>  MODULE_DEVICE_TABLE(tee, tee_stmm_efi_id_table);
>
>  static struct tee_client_driver tee_stmm_efi_driver = {
>         .id_table       = tee_stmm_efi_id_table,
> +       .probe          = tee_stmm_efi_probe,
> +       .remove         = tee_stmm_efi_remove,
>         .driver         = {
>                 .name           = "tee-stmm-efi",
> -               .probe          = tee_stmm_efi_probe,
> -               .remove         = tee_stmm_efi_remove,
>         },
>  };
>
> --
> 2.47.3
>