linux-kernel - Re: [PATCH] bug: hush suggest-attribute=format for __warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251216123647.22f81a16@pumpkin>
Date: Tue, 16 Dec 2025 12:36:47 +0000
From: David Laight <david.laight.linux@...il.com>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Andrew Morton
 <akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
 <kees@...nel.org>, <acarmina@...hat.com>, <jpoimboe@...nel.org>,
 <mark.rutland@....com>, <maciej.wieczor-retman@...el.com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Linus Torvalds
 <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf()

On Tue, 16 Dec 2025 09:16:41 +0000
Brendan Jackman <jackmanb@...gle.com> wrote:

...
> Given the kernel is usually W=1 clean, it seems like we _do_ support it.
> It's just that we support it via these akwkward retroactive fixups
> instead of just expecting code to be W=1-clean before we merge it?

It's not that W=1 clean, the bot remembers which warnings it has seen and
only reports new ones.

There are some entirely annoying ones that haven't been moved to W=2.
Some need fixing in the compiler, for instance:
int foo[] = { [0 ... 3 ] = -1, [2] = 1 };
(to change the default initialiser)
generates a warning because [2] is initialised twice.
Any attempt to 'fix' that is likely to leave an unexpected 0 entry.

The 'suggest-attribute-format' one used to give false positives on
some architectures (IIRC including x86) for some vprintf-like functions
because va_list is 'char *'.
That must not be true for kernel builds (any more).

	David