linux-kernel - Re: [PATCH] bug: hush suggest-attribute=format for __warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+i-1C0nGz+==UVbKKYxbYEYP_=YH6Oy2O__Vj+oFWp7a_DGSw@mail.gmail.com>
Date: Tue, 16 Dec 2025 13:43:20 +0100
From: Brendan Jackman <jackmanb@...gle.com>
To: David Laight <david.laight.linux@...il.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Andrew Morton <akpm@...ux-foundation.org>, 
	linux-kernel@...r.kernel.org, kees@...nel.org, acarmina@...hat.com, 
	jpoimboe@...nel.org, mark.rutland@....com, maciej.wieczor-retman@...el.com, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf()

On Tue, 16 Dec 2025 at 13:36, David Laight <david.laight.linux@...il.com> wrote:
>
> On Tue, 16 Dec 2025 09:16:41 +0000
> Brendan Jackman <jackmanb@...gle.com> wrote:
>
> ...
> > Given the kernel is usually W=1 clean, it seems like we _do_ support it.
> > It's just that we support it via these akwkward retroactive fixups
> > instead of just expecting code to be W=1-clean before we merge it?
>
> It's not that W=1 clean, the bot remembers which warnings it has seen and
> only reports new ones.

I haven't been doing it for long, but I build with W=1 in Github
Actions [0] and this suggest-attribute-format is the first issue
that's come up there. I don't have any logic to exclude pre-existing
errors.

I am only building a pretty small config there (enough to run a few
selftests on QEMU) but it does suggest that people "support" W=1 at
least for the core kernel code.

[0] https://github.com/bjackman/limmat-kernel-nix