linux-kernel - Re: [PATCH] staging: rtl8723bs: clean up redundant parentheses in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025121704-unroasted-faculty-a76f@gregkh>
Date: Wed, 17 Dec 2025 14:09:50 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Darshil Shah <darshilshah7070@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: clean up redundant parentheses in
 rtw_mlme.c

On Tue, Dec 16, 2025 at 02:39:01AM +0530, Darshil Shah wrote:
> - Removed unnecessary parentheses around if conditions

Only one if condition was changed.

> - Removed redundant '== true' and '== false' comparisons

Ok,I see why you removed this at the same time, but really, it was not
redundant, you just changed the operator to something else.

But why?  It's not really required by anything, what is driving this
change?

thanks,

greg k-h