linux-kernel - Re: [PATCH] staging: rtl8723bs: clean up redundant parentheses in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGQ2yWnj2peEqhEeZps5w7=SqSaFR6WXy2E-2DzN6Qf3U517CQ@mail.gmail.com>
Date: Wed, 17 Dec 2025 19:14:41 +0530
From: Darshil Shah <darshilshah7070@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: clean up redundant parentheses in rtw_mlme.c

Thanks for the clarification.

This was intended as a minor style cleanup only.
Since there is no functional impact, I agree it’s not necessary.
I’ll drop this patch.

Thanks for the review.


On Wed, Dec 17, 2025 at 7:06 PM Darshil Shah <darshilshah7070@...il.com> wrote:
>
> Thanks for the clarification.
>
> This was intended as a minor style cleanup only.
> Since there is no functional impact, I agree it’s not necessary.
> I’ll drop this patch.
>
> Thanks for the review.
>
> On Wed, Dec 17, 2025 at 6:39 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>>
>> On Tue, Dec 16, 2025 at 02:39:01AM +0530, Darshil Shah wrote:
>> > - Removed unnecessary parentheses around if conditions
>>
>> Only one if condition was changed.
>>
>> > - Removed redundant '== true' and '== false' comparisons
>>
>> Ok,I see why you removed this at the same time, but really, it was not
>> redundant, you just changed the operator to something else.
>>
>> But why?  It's not really required by anything, what is driving this
>> change?
>>
>> thanks,
>>
>> greg k-h