linux-kernel - Re: [PATCH v4 2/4] selftests/resctrl: Define CPU vendor IDs as bits to match usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <619c0a29-7c98-4b2d-93ad-c5576796480d@open-hieco.net>
Date: Wed, 17 Dec 2025 10:36:33 +0800
From: Xiaochen Shen <shenxiaochen@...n-hieco.net>
To: Reinette Chatre <reinette.chatre@...el.com>, tony.luck@...el.com,
 bp@...en8.de, fenghuay@...dia.com, shuah@...nel.org,
 skhan@...uxfoundation.org
Cc: babu.moger@....com, james.morse@....com, Dave.Martin@....com,
 x86@...nel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, shenxiaochen@...n-hieco.net
Subject: Re: [PATCH v4 2/4] selftests/resctrl: Define CPU vendor IDs as bits
 to match usage

Hi Reinette,

On 12/17/2025 7:26 AM, Reinette Chatre wrote:
>> -static int detect_vendor(void)
>> +static unsigned int detect_vendor(void)
>>  {
>> -	FILE *inf = fopen("/proc/cpuinfo", "r");
>> -	int vendor_id = 0;
>> +	FILE *inf;
>> +	static unsigned int vendor_id;
>>  	char *s = NULL;
>>  	char *res;
>> +	static bool initialized;
>>  
> The changelog incorrectly claims that this should now match reverse fir ordering.
> To be "reverse fir" ordered the declarations should look like:
> 
> 	static unsigned int vendor_id;                                          
> 	static bool initialized;                                                
> 	char *s = NULL;                                                         
> 	FILE *inf;                                                              
> 	char *res;             

Thank you! I will fix it on v5 patch.


> 
> 
> With this fixed:
> | Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Thank you!


Best regards,
Xiaochen Shen