linux-kernel - Re: [PATCH 07/11] ASoC: dt-bindings: add avdd and iovdd supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebbe7852-6f1d-4bfe-995d-5d6d668e9961@kernel.org>
Date: Wed, 17 Dec 2025 15:29:36 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sascha Hauer <s.hauer@...gutronix.de>,
 Shenghao Ding <shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>,
 Baojun Xu <baojun.xu@...com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Clark Williams <clrkwllms@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
 Dan Murphy <dmurphy@...com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 Kevin Lu <luminlong@....com>, linux-rt-devel@...ts.linux.dev,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 07/11] ASoC: dt-bindings: add avdd and iovdd supply

On 17/12/2025 14:54, Sascha Hauer wrote:
> Add bindings for the avdd-supply and iovdd-supply which are named after
> the corresponding pins on the tlv320adcx140 chips.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> ---
>  Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> index 876fa97bfbcdd3b9450aa6ff57de42f1faed350d..0f043a51f1822f4d39214438818e3bc84d3e8681 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> @@ -44,6 +44,16 @@ properties:
>        Regulator with AVDD at 3.3V.  If not defined then the internal regulator
>        is enabled.
>  
> +  avdd-supply:
> +    description: |
> +      Provide a handle to the regulator supplying AVDD. If not provided, a dummy
> +      regulator will be used.

Drop description, you did not say anything useful. Core already tells
this is phandle, "AVDD" duplicates property name and Linux kernel
behavior is here irrelevant.

If BSD does not create a dummy regulator, does this mean binding is wrong?

The bigger problem is that you are duplicating AVDD already described
under name areg. At least that's my impression and commit msg idd not
clarify anything here.

Best regards,
Krzysztof