linux-kernel - Re: [PATCH 08/11] ASoC: dt-bindings: clarify areg-supply documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07f8f657-8d9e-4310-ad9b-99fa6055eb5e@kernel.org>
Date: Wed, 17 Dec 2025 15:30:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sascha Hauer <s.hauer@...gutronix.de>,
 Shenghao Ding <shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>,
 Baojun Xu <baojun.xu@...com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Clark Williams <clrkwllms@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
 Dan Murphy <dmurphy@...com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 Kevin Lu <luminlong@....com>, linux-rt-devel@...ts.linux.dev,
 devicetree@...r.kernel.org, Emil-Juhl <emdj@...g-olufsen.dk>
Subject: Re: [PATCH 08/11] ASoC: dt-bindings: clarify areg-supply
 documentation

On 17/12/2025 14:54, Sascha Hauer wrote:
> From: Emil-Juhl <emdj@...g-olufsen.dk>
> 
> The documentation for areg-supply could cause confusion mainly in terms
> of the relationship between AREG and AVDD.
> According to the datasheet[1] the AREG can be one of two cases:
> 
> 1) an external 1.8V supply
> 2) generated by an internal regulator (hence a 1.8V output)
> 
> [1] https://www.ti.com/lit/ds/symlink/tlv320adc5140.pdf
> 

Incomplete DCO chain.


> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> ---
>  Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> index 0f043a51f1822f4d39214438818e3bc84d3e8681..0c550c04f5ef239f403bea668ffd8c6051d86821 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> @@ -41,8 +41,8 @@ properties:
>  
>    areg-supply:
>      description: |
> -      Regulator with AVDD at 3.3V.  If not defined then the internal regulator
> -      is enabled.
> +      External supply of 1.8V. If not defined then the internal regulator is
> +      enabled instead.

Please re-order the patches. Fixes are always before new features and
you would solve yourself one review question...

Best regards,
Krzysztof