linux-kernel - Re: [PATCH v3] block: add allocation size check in blkdev_pr_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176598217497.7122.17206763785166141358.b4-ty@kernel.dk>
Date: Wed, 17 Dec 2025 07:36:14 -0700
From: Jens Axboe <axboe@...nel.dk>
To: martin.petersen@...cle.com, stefanha@...hat.com, 
 Deepanshu Kartikey <kartikey406@...il.com>
Cc: hare@...e.de, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, 
 syzbot+660d079d90f8a1baf54d@...kaller.appspotmail.com
Subject: Re: [PATCH v3] block: add allocation size check in
 blkdev_pr_read_keys()


On Wed, 17 Dec 2025 07:17:12 +0530, Deepanshu Kartikey wrote:
> blkdev_pr_read_keys() takes num_keys from userspace and uses it to
> calculate the allocation size for keys_info via struct_size(). While
> there is a check for SIZE_MAX (integer overflow), there is no upper
> bound validation on the allocation size itself.
> 
> A malicious or buggy userspace can pass a large num_keys value that
> doesn't trigger overflow but still results in an excessive allocation
> attempt, causing a warning in the page allocator when the order exceeds
> MAX_PAGE_ORDER.
> 
> [...]

Applied, thanks!

[1/1] block: add allocation size check in blkdev_pr_read_keys()
      commit: a58383fa45c706bda3bf4a1955c3a0327dbec7e7

Best regards,
-- 
Jens Axboe