linux-kernel - Re: [PATCH v3] block: add allocation size check in blkdev_pr_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1ike542t5.fsf@ca-mkp.ca.oracle.com>
Date: Wed, 17 Dec 2025 09:12:23 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Deepanshu Kartikey <kartikey406@...il.com>
Cc: axboe@...nel.dk, martin.petersen@...cle.com, stefanha@...hat.com,
        hare@...e.de, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        syzbot+660d079d90f8a1baf54d@...kaller.appspotmail.com
Subject: Re: [PATCH v3] block: add allocation size check in
 blkdev_pr_read_keys()


Deepanshu,

> blkdev_pr_read_keys() takes num_keys from userspace and uses it to
> calculate the allocation size for keys_info via struct_size(). While
> there is a check for SIZE_MAX (integer overflow), there is no upper
> bound validation on the allocation size itself.

LGTM.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen