linux-kernel - Re: [PATCH 2/2] nvme/host: fixup some typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1afe4a52-2c61-4441-8e6c-5cee343d7419@kernel.org>
Date: Wed, 17 Dec 2025 10:42:38 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Wilfred Mallawa <wilfred.opensource@...il.com>,
 James Smart <james.smart@...adcom.com>, Keith Busch <kbusch@...nel.org>,
 Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
 Sagi Grimberg <sagi@...mberg.me>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Wilfred Mallawa <wilfred.mallawa@....com>
Subject: Re: [PATCH 2/2] nvme/host: fixup some typos

On 12/16/25 12:29, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@....com>
> 
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@....com>

Looks good, but write something as the commit message.

One nit below.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>


> @@ -271,7 +271,7 @@ static bool nvme_validate_passthru_nsid(struct nvme_ctrl *ctrl,
>  {
>  	if (ns && nsid != ns->head->ns_id) {
>  		dev_err(ctrl->device,
> -			"%s: nsid (%u) in cmd does not match nsid (%u)"
> +			"%s: nsid (%u) in cmd does not match nsid (%u) "
>  			"of namespace\n",

I know that Christoph does not like long lines, but it may be better to unwrap
this message to make it easier to grep the code.


-- 
Damien Le Moal
Western Digital Research