linux-kernel - Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add ov2732 image sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <749e8633-1742-4e03-b1fd-2a601f218a0a@kernel.org>
Date: Thu, 18 Dec 2025 21:02:20 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Walter Werner Schneider <contact@...nwalter.eu>,
 linux-media@...r.kernel.org, Jacopo Mondi <jacopo.mondi@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add ov2732 image sensor

On 18/12/2025 19:15, Walter Werner Schneider wrote:
> +  avdd-supply:
> +    description: Analog Domain Power Supply
> +
> +  dovdd-supply:
> +    description: I/O Domain Power Supply
> +
> +  dvdd-supply:
> +    description: Digital Domain Power Supply
> +
> +  pwdn-gpios:

Use name from gpio-consumer-common, so "powerdown-gpios".

> +    maxItems: 1
> +    description: Reference to the GPIO connected to the pwdn pin. Active high.

high?

> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: Reference to the GPIO connected to the reset pin. Active high.

Are you sure this is active high?

> +
> +  port:
> +    description: MIPI CSI-2 transmitter port
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            items:
> +              - const: 1
> +              - const: 2
> +          link-frequencies: true

Drop

> +          remote-endpoint: true

Drop

> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +          - remote-endpoint

Drop remote endpoint

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - avdd-supply
> +  - dovdd-supply
> +  - dvdd-supply
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ov2732: camera@36 {
> +            compatible = "ovti,ov2732";
> +            reg = <0x36>;
> +            clocks = <&ov2732_clk>;
> +            clock-names = "xvclk";
> +
> +            avdd-supply = <&ov2732_avdd>;
> +            dovdd-supply = <&ov2732_dovdd>;
> +            dvdd-supply = <&ov2732_dvdd>;
> +
> +            pwdn-gpios = <&gpio0 13 GPIO_ACTIVE_LOW>;
> +            reset-gpios = <&gpio0 8 GPIO_ACTIVE_LOW>;

And here (probably correct) active low?



Best regards,
Krzysztof