linux-kernel - Re: [PATCH] net: wangxun: move PHYLINK dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26cb5301-bd57-479c-a0f0-6358432ebe76@linux.dev>
Date: Thu, 18 Dec 2025 06:47:17 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Arnd Bergmann <arnd@...nel.org>, Jiawen Wu <jiawenwu@...stnetic.com>,
 Mengyuan Lou <mengyuanlou@...-swift.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>
Cc: Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: wangxun: move PHYLINK dependency

On 16/12/2025 21:35, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The LIBWX library code is what calls into phylink, so any user of
> it has to select CONFIG_PHYLINK at the moment, with NGBEVF missing this:
> 
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset':
> wx_ethtool.c:(.text+0x613): undefined reference to `phylink_ethtool_nway_reset'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_link_ksettings':
> wx_ethtool.c:(.text+0x62b): undefined reference to `phylink_ethtool_ksettings_get'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_link_ksettings':
> wx_ethtool.c:(.text+0x643): undefined reference to `phylink_ethtool_ksettings_set'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_pauseparam':
> wx_ethtool.c:(.text+0x65b): undefined reference to `phylink_ethtool_get_pauseparam'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_pauseparam':
> wx_ethtool.c:(.text+0x677): undefined reference to `phylink_ethtool_set_pauseparam'
> 
> Add the 'select PHYLINK' line in the libwx option directly so this will
> always be enabled for all current and future wangxun drivers, and remove
> the now duplicate lines.
> 
> Fixes: a0008a3658a3 ("net: wangxun: add ngbevf build")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/net/ethernet/wangxun/Kconfig | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> index d138dea7d208..ec278f99d295 100644
> --- a/drivers/net/ethernet/wangxun/Kconfig
> +++ b/drivers/net/ethernet/wangxun/Kconfig
> @@ -21,6 +21,7 @@ config LIBWX
>   	depends on PTP_1588_CLOCK_OPTIONAL
>   	select PAGE_POOL
>   	select DIMLIB
> +	select PHYLINK
>   	help
>   	Common library for Wangxun(R) Ethernet drivers.
>   
> @@ -29,7 +30,6 @@ config NGBE
>   	depends on PCI
>   	depends on PTP_1588_CLOCK_OPTIONAL
>   	select LIBWX
> -	select PHYLINK
>   	help
>   	  This driver supports Wangxun(R) GbE PCI Express family of
>   	  adapters.
> @@ -48,7 +48,6 @@ config TXGBE
>   	depends on PTP_1588_CLOCK_OPTIONAL
>   	select MARVELL_10G_PHY
>   	select REGMAP
> -	select PHYLINK
>   	select HWMON if TXGBE=y
>   	select SFP
>   	select GPIOLIB
> @@ -71,7 +70,6 @@ config TXGBEVF
>   	depends on PCI_MSI
>   	depends on PTP_1588_CLOCK_OPTIONAL
>   	select LIBWX
> -	select PHYLINK
>   	help
>   	  This driver supports virtual functions for SP1000A, WX1820AL,
>   	  WX5XXX, WX5XXXAL.

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>