linux-kernel - Re: [PATCH] VFS: fix dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUOjqBtYX-rafsvU@archie.me>
Date: Thu, 18 Dec 2025 13:48:08 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	Benjamin Coddington <bcodding@...merspace.com>,
	Jeff Layton <jlayton@...nel.org>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] VFS: fix dentry_create() kernel-doc comment

On Thu, Dec 18, 2025 at 06:10:56AM +0000, Al Viro wrote:
> The first one might be borderline sane (I'd probably go for O_... instead
> of O_, but whatever); the second is not.

Or O_\* flags?

> 
> Forget kernel-doc; what is that phrase supposed to mean in the
> first place?  "struct file *" (in quotes, for whatever reason)
> would presumably imply a value of mentioned type; a function
> declared as
> struct file *dentry_create(const struct path *path, int flags, umode_t mode,
>                            const struct cred *cred)
> *always* returns a value of that type, TYVM.
> 
> I'm not a native speaker, but I'd suggest something along the lines
> of "a pointer to opened file" as replacement for that (without
> quote marks, obviously).

Ack. Will apply your suggestions in v2.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)