linux-kernel - RE: [PATCH 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD, ECC_ERROR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY8PR11MB713473676F8A72C759A843FE89A8A@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Thu, 18 Dec 2025 00:44:30 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: "Luck, Tony" <tony.luck@...el.com>
CC: Borislav Petkov <bp@...en8.de>, "Gao, Jianfeng" <jianfeng.gao@...el.com>,
	"Lai, Yi1" <yi1.lai@...el.com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD,
 ECC_ERROR_LOG} configurable

> From: Luck, Tony <tony.luck@...el.com>
> Sent: Thursday, December 18, 2025 2:19 AM
> To: Zhuo, Qiuxu <qiuxu.zhuo@...el.com>
> Cc: Borislav Petkov <bp@...en8.de>; Gao, Jianfeng <jianfeng.gao@...el.com>;
> Lai, Yi1 <yi1.lai@...el.com>; linux-edac@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD,
> ECC_ERROR_LOG} configurable
> 
> On Mon, Nov 24, 2025 at 02:54:57PM +0800, Qiuxu Zhuo wrote:
> > diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c
> > index 5d887a3115f0..db4aa9f581e3 100644
> > --- a/drivers/edac/igen6_edac.c
> > +++ b/drivers/edac/igen6_edac.c
> ...
> > +/* Non-constant mask variant of FIELD_GET() */ #define
> > +field_get(mask, reg)  (((reg) & (mask)) >> (ffs(mask) - 1))
> 
> I applied to v6.19-rc1. But when building with make W=1 I get this warning:
> 
> drivers/edac/igen6_edac.c:125:9: warning: "field_get" redefined
>   125 | #define field_get(mask, reg)  (((reg) & (mask)) >> (ffs(mask) - 1))
>       |         ^~~~~~~~~

Thanks Tony for reporting this warning.

A global non-constant field_get() helper is now included in <linux/bitfield.h> from 
v6.19-rc1,  so the driver doesn't need to define it locally.

I'll remove the local field_get() definition from the driver in v2 to fix this warning.

-Qiuxu