linux-kernel - Re: [PATCH 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD, ECC_ERROR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUL0FlWTViEJHOKi@agluck-desk3>
Date: Wed, 17 Dec 2025 10:19:02 -0800
From: "Luck, Tony" <tony.luck@...el.com>
To: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
CC: Borislav Petkov <bp@...en8.de>, Jianfeng Gao <jianfeng.gao@...el.com>, "Yi
 Lai" <yi1.lai@...el.com>, <linux-edac@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD,
 ECC_ERROR_LOG} configurable

On Mon, Nov 24, 2025 at 02:54:57PM +0800, Qiuxu Zhuo wrote:
> diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c
> index 5d887a3115f0..db4aa9f581e3 100644
> --- a/drivers/edac/igen6_edac.c
> +++ b/drivers/edac/igen6_edac.c
...
> +/* Non-constant mask variant of FIELD_GET() */
> +#define field_get(mask, reg)  (((reg) & (mask)) >> (ffs(mask) - 1))

I applied to v6.19-rc1. But when building with make W=1 I get this warning:

drivers/edac/igen6_edac.c:125:9: warning: "field_get" redefined
  125 | #define field_get(mask, reg)  (((reg) & (mask)) >> (ffs(mask) - 1))
      |         ^~~~~~~~~
In file included from ./include/linux/fortify-string.h:5,
                 from ./include/linux/string.h:386,
                 from ./include/linux/bitmap.h:13,
                 from ./include/linux/cpumask.h:11,
                 from ./arch/x86/include/asm/paravirt.h:21,
                 from ./arch/x86/include/asm/cpuid/api.h:57,
                 from ./arch/x86/include/asm/processor.h:19,
                 from ./arch/x86/include/asm/timex.h:5,
                 from ./include/linux/timex.h:67,
                 from ./include/linux/time32.h:13,
                 from ./include/linux/time.h:60,
                 from ./include/linux/stat.h:19,
                 from ./include/linux/module.h:13,
                 from drivers/edac/igen6_edac.c:13:
./include/linux/bitfield.h:298:9: note: this is the location of the previous definition
  298 | #define field_get(mask, reg)                                            \

-Tony