linux-kernel - Re: [PATCH 4/4] selftests/mm: fix exit code in pagemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d59597c-5a32-4c97-93ef-feb8dc15b674@kernel.org>
Date: Thu, 18 Dec 2025 09:07:14 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Kevin Brodsky <kevin.brodsky@....com>, linux-mm@...ck.org,
 linux-kselftest@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Mark Brown
 <broonie@...nel.org>, Ryan Roberts <ryan.roberts@....com>,
 Shuah Khan <shuah@...nel.org>, Usama Anjum <Usama.Anjum@....com>
Subject: Re: [PATCH 4/4] selftests/mm: fix exit code in pagemap_ioctl

On 12/16/25 15:26, Kevin Brodsky wrote:
> pagemap_ioctl always reports success, whether the tests succeeded or
> not. Call ksft_finished() to report the right status.
> 
> While at it also fix the exit code in unexpected situations:
> 
> - Report SKIP if userfaultfd isn't available (in line with other
>    tests)
> 
> - Report FAIL if we failed to open /proc/self/pagemap (returning
>    -EINVAL from main() is meaningless)
> 
> Cc: Usama Anjum <Usama.Anjum@....com>
> Signed-off-by: Kevin Brodsky <kevin.brodsky@....com>
> ---

Fine for me to fix return handling for the overall test in a single patch

Acked-by: David Hildenbrand (Red Hat) <david@...nel.org>

-- 
Cheers

David