linux-kernel - Re: [PATCH 2/4] selftests/mm: pass down full CC and CFLAGS to check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d4e08d3-db9e-4b0e-8229-9e7ac1b58708@kernel.org>
Date: Thu, 18 Dec 2025 09:04:06 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Kevin Brodsky <kevin.brodsky@....com>, linux-mm@...ck.org,
 linux-kselftest@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Mark Brown
 <broonie@...nel.org>, Ryan Roberts <ryan.roberts@....com>,
 Shuah Khan <shuah@...nel.org>, Jason Gunthorpe <jgg@...dia.com>,
 John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH 2/4] selftests/mm: pass down full CC and CFLAGS to
 check_config.sh

On 12/16/25 15:26, Kevin Brodsky wrote:
> check_config.sh checks that liburing is available by running the
> compiler provided as its first argument. This makes two assumptions:
> 
> 1. CC consists of only one word
> 2. No extra flag is required
> 
> Unfortunately, there are many situations where these assumptions
> don't hold. For instance:
> 
> - When using Clang, CC consists of multiple words
> - When cross-compiling, extra flags may be required to allow the
>    compiler to find headers
> 
> Remove these assumptions by passing down CC and CFLAGS as-is from
> the Makefile, so that the same command line is used as when actually
> building the tests.
> 
> Cc: Jason Gunthorpe <jgg@...dia.com>
> Cc: John Hubbard <jhubbard@...dia.com>
> Signed-off-by: Kevin Brodsky <kevin.brodsky@....com>
> ---

Looks reasonable to me and I hope we find no surpirses :)

Acked-by: David Hildenbrand (Red Hat) <david@...nel.org>

-- 
Cheers

David