| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251218011414.1781294-4-samasth.norway.ananda@oracle.com> Date: Wed, 17 Dec 2025 17:14:13 -0800 From: Samasth Norway Ananda <samasth.norway.ananda@...cle.com> To: gregkh@...uxfoundation.org Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: [PATCH 3/4] staging: rtl8723bs: add IS_ERR() check for kthread_run() Add missing error check for kthread_run() in rtl8723b_start_thread(). kthread_run() returns an ERR_PTR on failure, not NULL. Without this check, rtl8723b_stop_thread() would later check "if (xmitpriv->SdioXmitThread)" which evaluates to true for error pointers, potentially causing issues when trying to complete or wait on an invalid thread. This follows the same pattern used elsewhere in the driver, such as in os_dep/os_intfs.c where IS_ERR() is properly checked after kthread_run() calls. Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@...cle.com> --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 0eae624a36f0..88ea3518bb67 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -2926,6 +2926,8 @@ void rtl8723b_start_thread(struct adapter *padapter) struct xmit_priv *xmitpriv = &padapter->xmitpriv; xmitpriv->SdioXmitThread = kthread_run(rtl8723bs_xmit_thread, padapter, "RTWHALXT"); + if (IS_ERR(xmitpriv->SdioXmitThread)) + xmitpriv->SdioXmitThread = NULL; } void rtl8723b_stop_thread(struct adapter *padapter) -- 2.50.1
Powered by blists - more mailing lists