| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251218011414.1781294-5-samasth.norway.ananda@oracle.com> Date: Wed, 17 Dec 2025 17:14:14 -0800 From: Samasth Norway Ananda <samasth.norway.ananda@...cle.com> To: gregkh@...uxfoundation.org Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: [PATCH 4/4] staging: rtl8723bs: check return value of rtw_wdev_alloc() Add missing error check for rtw_wdev_alloc() in rtw_sdio_if1_init(). rtw_wdev_alloc() can fail with -ENOMEM when wiphy_new() or rtw_zmalloc() fails, or with other negative error codes when wiphy_register() fails. Without checking the return value, initialization continues even when wireless device allocation fails, potentially leaving the adapter in an inconsistent state. Jump to the error cleanup path when rtw_wdev_alloc() fails to ensure proper resource cleanup and prevent use of an incompletely initialized adapter. Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@...cle.com> --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index 1d0239eef114..432bc6aa1d90 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -296,7 +296,8 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct if (rtw_init_drv_sw(padapter) == _FAIL) goto free_hal_data; - rtw_wdev_alloc(padapter, dvobj_to_dev(dvobj)); + if (rtw_wdev_alloc(padapter, dvobj_to_dev(dvobj))) + goto free_hal_data; /* 3 8. get WLan MAC address */ /* set mac addr */ -- 2.50.1
Powered by blists - more mailing lists