linux-kernel - Re: [PATCH v2] net: usb: asix: validate PHY address before use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d49a5ec7-219b-4991-a5d3-b8705f6d2ec4@lunn.ch>
Date: Thu, 18 Dec 2025 11:17:08 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Deepanshu Kartikey <kartikey406@...il.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, khalasa@...p.pl,
	andriy.shevchenko@...ux.intel.com, o.rempel@...gutronix.de,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	syzbot+3d43c9066a5b54902232@...kaller.appspotmail.com
Subject: Re: [PATCH v2] net: usb: asix: validate PHY address before use

On Thu, Dec 18, 2025 at 06:41:56AM +0530, Deepanshu Kartikey wrote:
> The ASIX driver reads the PHY address from the USB device via
> asix_read_phy_addr(). A malicious or faulty device can return an
> invalid address (>= PHY_MAX_ADDR), which causes a warning in
> mdiobus_get_phy():
> 
>   addr 207 out of range
>   WARNING: drivers/net/phy/mdio_bus.c:76
> 
> Validate the PHY address in asix_read_phy_addr() and remove the
> now-redundant check in ax88172a.c.
> 
> Reported-by: syzbot+3d43c9066a5b54902232@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=3d43c9066a5b54902232
> Tested-by: syzbot+3d43c9066a5b54902232@...kaller.appspotmail.com
> Fixes: 7e88b11a862a ("net: usb: asix: refactor asix_read_phy_addr() and handle errors on return")
> Link: https://lore.kernel.org/all/20251217085057.270704-1-kartikey406@gmail.com/T/ [v1]
> Signed-off-by: Deepanshu Kartikey <kartikey406@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew