linux-kernel - Re: [PATCH] platform/x86: think-lmi: Add WMI certificate thumbprint support for ThinkCenter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <32d95a0f-4027-4ae7-811c-cef18a48c41c@app.fastmail.com>
Date: Fri, 19 Dec 2025 10:38:49 -0500
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
Cc: "Hans de Goede" <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: think-lmi: Add WMI certificate thumbprint support
 for ThinkCenter

On Thu, Nov 27, 2025, at 3:29 PM, Mark Pearson wrote:
> The ThinkCenter team are adding WMI certificate thumbprint support.
>
> Updating the driver to enable it. They are using the same GUID as
> Thinkpad/ThinkStation.
> Tested on M75q Gen 5.
>
> Signed-off-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
> ---
>  drivers/platform/x86/lenovo/think-lmi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/lenovo/think-lmi.c 
> b/drivers/platform/x86/lenovo/think-lmi.c
> index 540b472b1bf3..c45f0206b4ab 100644
> --- a/drivers/platform/x86/lenovo/think-lmi.c
> +++ b/drivers/platform/x86/lenovo/think-lmi.c
> @@ -195,7 +195,7 @@ static const struct tlmi_cert_guids 
> thinkpad_cert_guid = {
>  };
> 
>  static const struct tlmi_cert_guids thinkcenter_cert_guid = {
> -	.thumbprint = NULL,
> +	.thumbprint = LENOVO_CERT_THUMBPRINT_GUID, /* Same GUID as TP */
>  	.set_bios_setting = LENOVO_TC_SET_BIOS_SETTING_CERT_GUID,
>  	.save_bios_setting = LENOVO_TC_SAVE_BIOS_SETTING_CERT_GUID,
>  	.cert_to_password = LENOVO_TC_CERT_TO_PASSWORD_GUID,
> @@ -709,6 +709,10 @@ static ssize_t cert_thumbprint(char *buf, const 
> char *arg, int count)
>  	if (!tlmi_priv.cert_guid->thumbprint)
>  		return -EOPNOTSUPP;
> 
> +	/* Older ThinkCenter BIOS may not have support */
> +	if (!wmi_has_guid(tlmi_priv.cert_guid->thumbprint))
> +		return -EOPNOTSUPP;
> +
>  	status = wmi_evaluate_method(tlmi_priv.cert_guid->thumbprint, 0, 0, 
> &input, &output);
>  	if (ACPI_FAILURE(status)) {
>  		kfree(output.pointer);
> -- 
> 2.43.0

Would it be possible to get a review for this please? It's pretty minor and would like to get this feature available to users.

Thanks
Mark