linux-kernel - Re: [PATCH v2] phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUV1gxwj3UtRwaro@lizhi-Precision-Tower-5810>
Date: Fri, 19 Dec 2025 10:55:47 -0500
From: Frank Li <Frank.li@....com>
To: Stefano Radaelli <stefano.radaelli21@...il.com>
Cc: vkoul@...nel.org, neil.armstrong@...aro.org, shawnguo@...nel.org,
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
	j.zink@...gutronix.de, linux-kernel@...r.kernel.org,
	xu.yang_2@....com, jun.li@....com, haibo.chen@....com,
	linux-phy@...ts.infradead.org, imx@...ts.linux.dev,
	Stefano Radaelli <stefano.r@...iscite.com>,
	Pierluigi Passaro <pierluigi.p@...iscite.com>
Subject: Re: [PATCH v2] phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL
 field before using it

On Thu, Dec 18, 2025 at 08:41:00PM +0100, Stefano Radaelli wrote:
> Clear the PCS_TX_SWING_FULL field mask before setting the new value
> in PHY_CTRL5 register. Without clearing the mask first, the OR operation
> could leave previously set bits, resulting in incorrect
> register configuration.

nit: can you wrap at 75 char, at lease move 'register' to above line.

Reviewed-by: Frank Li <Frank.Li@....com>

>
> Fixes: 63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning")
> Suggested-by: Pierluigi Passaro <pierluigi.p@...iscite.com>
> Signed-off-by: Stefano Radaelli <stefano.r@...iscite.com>
> ---
> v2:
> - Improved commit subject as suggested by Fabio Estevam
>
>  drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> index ad8a55012e42..9458b6e5fcf4 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> @@ -504,6 +504,7 @@ static void imx8m_phy_tune(struct imx8mq_usb_phy *imx_phy)
>
>  	if (imx_phy->pcs_tx_swing_full != PHY_TUNE_DEFAULT) {
>  		value = readl(imx_phy->base + PHY_CTRL5);
> +		value &= ~PHY_CTRL5_PCS_TX_SWING_FULL_MASK;
>  		value |= FIELD_PREP(PHY_CTRL5_PCS_TX_SWING_FULL_MASK,
>  				   imx_phy->pcs_tx_swing_full);
>  		writel(value, imx_phy->base + PHY_CTRL5);
>
> base-commit: ea1013c1539270e372fc99854bc6e4d94eaeff66
> --
> 2.47.3
>