linux-kernel - Re: [PATCH] fpga: dfl: use subsys_initcall to allow built-in drivers to be added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUVyJkOxMrC/OEtr@yilunxu-OptiPlex-7050>
Date: Fri, 19 Dec 2025 23:41:26 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Thadeu Lima de Souza Cascardo <cascardo@...lia.com>
Cc: Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
	Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
	Matthew Gerlach <matthew.gerlach@...ux.intel.com>,
	Russ Weight <russell.h.weight@...el.com>,
	linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-dev@...lia.com
Subject: Re: [PATCH] fpga: dfl: use subsys_initcall to allow built-in drivers
 to be added

On Mon, Dec 15, 2025 at 04:05:50PM -0300, Thadeu Lima de Souza Cascardo wrote:
> The dfl code adds a bus. If it is built-in and there is a built-in driver
> as well, the dfl module_init may be called after the driver module_init,
> leading to a failure to register the driver as the bus has not been added
> yet.
> 
> Use subsys_initcall, which guarantees it will be called before the drivers
> init code.
> 
> Without the fix, we see failures like this:
> 
> [    0.479475] Driver 'intel-m10-bmc' was unable to register with bus_type 'dfl' because the bus was not initialized.
> 
> Fixes: 9ba3a0aa09fe ("fpga: dfl: create a dfl bus type to support DFL devices")

I will add:

 Cc: stable@...r.kernel.org

> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...lia.com>

Reviewed-by: Xu Yilun <yilun.xu@...el.com>

Applied to for-next, thanks.