linux-kernel - [PATCH] powercap: dtpm: Fix format string issues in log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251219184521.379599-1-sumeet4linux@gmail.com>
Date: Sat, 20 Dec 2025 00:15:20 +0530
From: Sumeet Pawnikar <sumeet4linux@...il.com>
To: daniel.lezcano@...nel.org,
	rafael@...nel.org,
	linux-pm@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
	sumeet4linux@...il.com
Subject: [PATCH] powercap: dtpm: Fix format string issues in log messages

Fix few format string issues in dtpm.c file,
- Extra trailing comma and space in the debug message "Registered
dtpm node '%s' / %llu-%llu uW, \n". This unnecessary trailing ", "
before the newline character, resulting an illusion of some more
message available for this under debug output.

- Incorrect log level for subsystem initialization failure message.
There is an error condition, not informational, and should be logged
at error level for consistency with other failure mssages. Changed
pr_info() to pr_err() for this subsystem initialization failure
message.

- The same error message "Failed to initialize '%s': %d" has missing
a trailing newline, which could cause log messages to be concatenated
incorrectly, making the logs harder to read.

These isseus affect log readability and consistency but do not impact
any functionality.

Signed-off-by: Sumeet Pawnikar <sumeet4linux@...il.com>
---
 drivers/powercap/dtpm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c
index 129d55bc705c..2179f5c0fbbe 100644
--- a/drivers/powercap/dtpm.c
+++ b/drivers/powercap/dtpm.c
@@ -406,7 +406,7 @@ int dtpm_register(const char *name, struct dtpm *dtpm, struct dtpm *parent)
 		dtpm->power_limit = dtpm->power_max;
 	}
 
-	pr_debug("Registered dtpm node '%s' / %llu-%llu uW, \n",
+	pr_debug("Registered dtpm node '%s' / %llu-%llu uW\n",
 		 dtpm->zone.name, dtpm->power_min, dtpm->power_max);
 
 	return 0;
@@ -582,7 +582,7 @@ int dtpm_create_hierarchy(struct of_device_id *dtpm_match_table)
 
 		ret = dtpm_subsys[i]->init();
 		if (ret)
-			pr_info("Failed to initialize '%s': %d",
+			pr_err("Failed to initialize '%s': %d\n",
 				dtpm_subsys[i]->name, ret);
 	}
 
-- 
2.43.0