linux-kernel - Re: [PATCH] powercap: dtpm: Fix format string issues in log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gxm2KJ11jqsL355kjkAAb=y_L+kq5i_JSZB8LxkBV+Uw@mail.gmail.com>
Date: Wed, 7 Jan 2026 21:54:10 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Sumeet Pawnikar <sumeet4linux@...il.com>
Cc: daniel.lezcano@...nel.org, rafael@...nel.org, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powercap: dtpm: Fix format string issues in log messages

On Fri, Dec 19, 2025 at 7:45 PM Sumeet Pawnikar <sumeet4linux@...il.com> wrote:
>
> Fix few format string issues in dtpm.c file,
> - Extra trailing comma and space in the debug message "Registered
> dtpm node '%s' / %llu-%llu uW, \n". This unnecessary trailing ", "
> before the newline character, resulting an illusion of some more
> message available for this under debug output.
>
> - Incorrect log level for subsystem initialization failure message.
> There is an error condition, not informational, and should be logged
> at error level for consistency with other failure mssages. Changed
> pr_info() to pr_err() for this subsystem initialization failure
> message.

Please leave it as is.

Error-level messages in the kernel log are only useful if the
user/admin of the system can do something about them, but this doesn't
seem to be the case here.