linux-kernel - Re: [PATCH] crypto: hisilicon/qm - fix incorrect judgment in qm_get_complete_eqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUT3IW8vlYKwWDt2@gondor.apana.org.au>
Date: Fri, 19 Dec 2025 14:56:33 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Chenghai Huang <huangchenghai2@...wei.com>
Cc: davem@...emloft.net, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, linuxarm@...neuler.org,
	liulongfang@...wei.com, qianweili@...wei.com,
	linwenkai6@...ilicon.com, wangzhou1@...ilicon.com
Subject: Re: [PATCH] crypto: hisilicon/qm - fix incorrect judgment in
 qm_get_complete_eqe_num()

On Thu, Nov 20, 2025 at 09:21:24PM +0800, Chenghai Huang wrote:
> In qm_get_complete_eqe_num(), the function entry has already
> checked whether the interrupt is valid, so the interrupt event
> can be processed directly. Currently, the interrupt valid bit is
> being checked again redundantly, and no interrupt processing is
> performed. Therefore, the loop condition should be modified to
> directly process the interrupt event, and use do while instead of
> the current while loop, because the condition is always satisfied
> on the first iteration.
> 
> Fixes: f5a332980a68 ("crypto: hisilicon/qm - add the save operation of eqe and aeqe")
> Signed-off-by: Chenghai Huang <huangchenghai2@...wei.com>
> ---
>  drivers/crypto/hisilicon/qm.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt