linux-kernel - Re: [PATCH 0/6] Support TQMa8QM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24355727.EfDdHjke4D@steina-w>
Date: Fri, 19 Dec 2025 09:52:15 +0100
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
 Peter Chen <peter.chen@...nel.org>, Pawel Laszczak <pawell@...ence.com>,
 Roger Quadros <rogerq@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Magnus Damm <magnus.damm@...il.com>,
 Marek Vasut <marex@...x.de>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-usb@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux@...tq-group.com
Subject: Re: [PATCH 0/6] Support TQMa8QM

Am Donnerstag, 18. Dezember 2025, 16:28:39 CET schrieb Geert Uytterhoeven:
> Hi Alexander,
> 
> On Thu, 18 Dec 2025 at 16:22, Alexander Stein
> <alexander.stein@...tq-group.com> wrote:
> > this series adds support for TQ's TQMa8QM. The first 3 patches are prepatory:
> > 1. Add support for clock-output-names for clk-renesas-pcie. This is necessary
> > as clk-imx8qxp-lpcg.c (driver for phyx1 phyx2 clock gating) reqiures that
> > property on the parent clock.
> 
> Hmm, clock consumers should have no business with the names used by
> clock providers, even less so whether those names are specified in DT
> or not.

Well drivers/clk/imx/clk-imx8qxp-lpcg.c does exactly this. AFAIK not just
the ones references in DT, but also hard codes ones.

The root cause is that clock-hsio-refa and clock-hsio-refb in
arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi are setting platform-specific
GPIOs in SoC .dtsi...

My current idea is to use fixed-factor-clock instead:

> &hsio_refa_clk {
> 	compatible = "fixed-factor-clock";
> 	clocks = <&pcieclk 0>;
> 	clock-div = <1>;
> 	clock-mult = <1>;
> 	/delete-property/ enable-gpios;
> };
> 
> &hsio_refb_clk {
> 	compatible = "fixed-factor-clock";
> 	clocks = <&pcieclk 0>;
> 	clock-div = <1>;
> 	clock-mult = <1>;
> 	/delete-property/ enable-gpios;
> };

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/