linux-kernel - Re: [PATCH] kunit: Enforce task execution in {soft,hard}irq contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOSm1=+13RijNG=8P=Pow3mdEjecLUG5fcP4g_AqFo5QBOw@mail.gmail.com>
Date: Fri, 19 Dec 2025 16:54:13 +0800
From: David Gow <davidgow@...gle.com>
To: Eric Biggers <ebiggers@...nel.org>, Brendan Higgins <brendan.higgins@...ux.dev>, 
	Rae Moar <raemoar63@...il.com>, Shuah Khan <skhan@...uxfoundation.org>
Cc: linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] kunit: Enforce task execution in {soft,hard}irq contexts

On Fri, 19 Dec 2025 at 16:08, David Gow <davidgow@...gle.com> wrote:
>
> The kunit_run_irq_test() helper allows a function to be run in hardirq
> and softirq contexts (in addition to the task context). It does this by
> running the user-provided function concurrently in the three contexts,
> until either a timeout has expired or a number of iterations have
> completed in the normal task context.
>
> However, on setups where the initialisation of the hardirq and softirq
> contexts (or, indeed, the scheduling of those tasks) is significantly
> slower than the function execution, it's possible for that number of
> iterations to be exceeded before any runs in irq contexts actually
> occur. This occurs with the polyval.test_polyval_preparekey_in_irqs
> test, which runs 20000 iterations of the relatively fast preparekey
> function, and therefore fails often under many UML, 32-bit arm, m68k and
> other environments.
>
> Instead, ensure that the max_iterations limit counts executions in all
> three contexts, and requires at least one of each. This will cause the
> test to continue iterating until at least the irq contexts have been
> tested, or the 1s wall-clock limit has been exceeded. This causes the
> test to pass in all of my environments.
>
> In so doing, we also update the task counters to atomic ints, to better
> match both the 'int' max_iterations input, and to ensure they are
> correctly updated across contexts.
>
> Finally, we also fix a few potential assertion messages to be
> less-specific to the original crypto usecases.
>
> Fixes: b41dc83f0790 ("kunit, lib/crypto: Move run_irq_test() to common header")
> Signed-off-by: David Gow <davidgow@...gle.com>
> ---
>  include/kunit/run-in-irq-context.h | 41 ++++++++++++++++++++----------
>  1 file changed, 28 insertions(+), 13 deletions(-)
>

.. snip ..

> @@ -85,6 +88,10 @@ static inline void kunit_run_irq_test(struct kunit *test, bool (*func)(void *),
>                 .test_specific_state = test_specific_state,
>         };
>         unsigned long end_jiffies;
> +       int hardirq_calls, softirq_calls;
> +       bool allctx = false;
> +
> +       max_iterations = 1;

Whoops! Left this debug line in.

v2 fixes it: https://lore.kernel.org/all/20251219085259.1163048-1-davidgow@google.com/

-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5281 bytes)