linux-kernel - Re: [PATCH v5 2/7] dt-bindings: wireless: ieee80211: Add disable-rfkill property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0e9e690-c56e-4b56-90f9-2af46a7feaf3@nxsw.ie>
Date: Sat, 20 Dec 2025 06:04:00 +0000
From: Bryan O'Donoghue <bod.linux@...w.ie>
To: jerome.debretagne@...il.com, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Johannes Berg <johannes@...solutions.net>,
 Lorenzo Bianconi <lorenzo@...nel.org>,
 Maximilian Luz <luzmaximilian@...il.com>, Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Jeff Johnson <jjohnson@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
 platform-driver-x86@...r.kernel.org, ath12k@...ts.infradead.org,
 Jeff Johnson <jeff.johnson@....qualcomm.com>, Dale Whinham <daleyo@...il.com>
Subject: Re: [PATCH v5 2/7] dt-bindings: wireless: ieee80211: Add
 disable-rfkill property

On 20/12/2025 00:21, Jérôme de Bretagne via B4 Relay wrote:
> From: Jérôme de Bretagne <jerome.debretagne@...il.com>
> 
> For some devices, Wi-Fi is entirely hard blocked by default making
> the Wi-Fi radio unusable, except if rfkill is disabled as expected
> on those models.
> 
> Commit c6a7c0b09d5f ("wifi: ath12k: Add Support for enabling or
> disabling specific features based on ACPI bitflag") added a way to
> support features set via ACPI, including the DISABLE_RFKILL bit.
> 
> Add a disable-rfkill property to expose the DISABLE_RFKILL bit
> equivalent for devices described by a Devicetree instead of ACPI.
> 
> Signed-off-by: Jérôme de Bretagne <jerome.debretagne@...il.com>
> ---
>   Documentation/devicetree/bindings/net/wireless/ieee80211.yaml | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> index d89f7a3f88a71d45d6f4ab2ae909eae09cbcaf9a..c10a4675640be947cd0b5eaec2c7ff367fd93945 100644
> --- a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> @@ -29,6 +29,12 @@ properties:
>         different 5 GHz subbands. Using them incorrectly could not work or
>         decrease performance noticeably
> 
> +  disable-rfkill:
> +    type: boolean
> +    description:
> +      Disable rfkill for some devices on which Wi-Fi would be entirely hard
> +      blocked by default otherwise
> +
>   additionalProperties: true
> 
>   examples:
> 
> --
> 2.47.3
> 
> 
> 

Is this really a hardware description though ?

Its really more of a logical/functional description. It tells the 
runtime what todo, not what the hardware is.

You could also have a list of quirks in ath12k for this or have a 
user-space utility look for the appropriate platform device string name 
and disable rfkill.

I think this logic belongs in drivers/net/wireless/ath/ath12k/ 
triggering on a compat string.

Should be achievable.

---
bod