linux-kernel - Re: [PATCH v4 11/19] mm, swap: split locked entry duplicating into a standalone helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUYfem4BPU9iQieE@MiWiFi-R3L-srv>
Date: Sat, 20 Dec 2025 12:00:58 +0800
From: Baoquan He <bhe@...hat.com>
To: Kairui Song <ryncsn@...il.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	Barry Song <baohua@...nel.org>, Chris Li <chrisl@...nel.org>,
	Nhat Pham <nphamcs@...il.com>, Yosry Ahmed <yosry.ahmed@...ux.dev>,
	David Hildenbrand <david@...nel.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Youngjun Park <youngjun.park@....com>,
	Hugh Dickins <hughd@...gle.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Ying Huang <ying.huang@...ux.alibaba.com>,
	Kemeng Shi <shikemeng@...weicloud.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 11/19] mm, swap: split locked entry duplicating into a
 standalone helper

On 12/20/25 at 01:26am, Kairui Song wrote:
> On Thu, Dec 18, 2025 at 2:37 AM Kairui Song <ryncsn@...il.com> wrote:
> >
> > On Wed, Dec 17, 2025 at 7:22 PM Baoquan He <bhe@...hat.com> wrote:
> > >
> > > On 12/05/25 at 03:29am, Kairui Song wrote:
> > > > From: Kairui Song <kasong@...cent.com>
> > > >
> > > > No feature change, split the common logic into a stand alone helper to
> > >                                                    ~~~~~~~~~~~
> > >                                                     standalone, typo?
> > > > be reused later.
> > >
> > > In phase 2, I saw the newly added swap_dup_entries() is only called by
> > > __swap_duplicate(). The 'reused later' means?
> > >
> >
> > Ah you are right, this patch belongs to phase 3 I think, I can drop it
> > for now, it's just a code rearrangement. Thanks!
> 
> Hi Baoquan
> 
> While working on V5 I noticed we do need this patch, the patch "mm,
> swap: use swap cache as the swap in synchronize layer" needs this
> splitted helper as an intermediate step. That usage will be dropped by
> the end of this series but I think we can live with this splitted out
> helper. The splitted helper and original help will all be gone in
> phase 3, and there is no behavior change at all.

That's fine to me, thanks for telling. I have some minor concers in
other patches, will add in v5.